Skip to content

Commit 2e04051

Browse files
committed
fix kernel dependency
1 parent 33cc2a2 commit 2e04051

File tree

1 file changed

+10
-11
lines changed

1 file changed

+10
-11
lines changed

applications/llama_3.2_1b/src/operator/aie_gemm.py

Lines changed: 10 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -82,19 +82,10 @@ def __init__(
8282

8383
def set_up(self):
8484
# Describe required artifacts (xclbin, insts.bin)
85-
# file_name_tile_base = f"{self.tile_m}x{self.tile_k}x{self.tile_n}"
85+
file_name_tile_base = f"{self.tile_m}x{self.tile_k}x{self.tile_n}"
8686
file_name_total_base = (
8787
f"{self.M}x{self.K}x{self.N}_{self.tile_m}x{self.tile_k}x{self.tile_n}"
8888
)
89-
# FIXME: We should be able to reuse the same xclbin for same tile
90-
# sizes, only swapping out the instruction sequence for different
91-
# problem sizes. However, there seem to be cases where this does
92-
# not work and the GEMM appears to be misconfigured for the wrong
93-
# size (resulting in a timeout when trying to run it). Perhaps
94-
# XRT is caching something, or something is wrong with the run-
95-
# time parameter (synchronization)? For now, create separate
96-
# xclbins for each problem size.
97-
file_name_tile_base = file_name_total_base
9889
xclbin_kernel_name = f"gemm_{file_name_tile_base}"
9990
kernel_flags = [
10091
f"-DDIM_M={self.tile_m}",
@@ -133,8 +124,16 @@ def set_up(self):
133124
requires_context=True,
134125
)
135126

127+
# FIXME: We should be able to reuse the same xclbin for same tile
128+
# sizes, only swapping out the instruction sequence for different
129+
# problem sizes. However, there seem to be cases where this does
130+
# not work and the GEMM appears to be misconfigured for the wrong
131+
# size (resulting in a timeout when trying to run it). Perhaps
132+
# XRT is caching something, or something is wrong with the run-
133+
# time parameter (synchronization)? For now, create separate
134+
# xclbins for each problem size.
136135
xclbin_artifact = XclbinArtifact.new(
137-
f"gemm_{file_name_tile_base}.xclbin",
136+
f"gemm_{file_name_total_base}.xclbin",
138137
depends=[
139138
mlir_artifact,
140139
KernelArchiveArtifact.new(

0 commit comments

Comments
 (0)