Skip to content

Commit bbe05e6

Browse files
committed
fix: misc cleanup across toolbar, fixtures, comment storage, and next config
1 parent e8176e0 commit bbe05e6

5 files changed

Lines changed: 18 additions & 27 deletions

File tree

packages/react-grab/e2e/fixtures.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1008,9 +1008,7 @@ const createReactGrabPageObject = (page: Page): ReactGrabPageObject => {
10081008
const items = dropdown.querySelectorAll<HTMLButtonElement>(
10091009
"[data-react-grab-menu-item]",
10101010
);
1011-
return Array.from(items).map(
1012-
(item) => item.textContent?.trim() ?? "",
1013-
);
1011+
return Array.from(items).map((item) => item.textContent?.trim() ?? "");
10141012
}
10151013
return [];
10161014
}, ATTRIBUTE_NAME);
@@ -1682,9 +1680,7 @@ const createReactGrabPageObject = (page: Page): ReactGrabPageObject => {
16821680
id: "comment-action",
16831681
label: "Edit",
16841682
shortcut: "Enter",
1685-
onAction: (context: {
1686-
enterPromptMode?: () => void;
1687-
}) => {
1683+
onAction: (context: { enterPromptMode?: () => void }) => {
16881684
context.enterPromptMode?.();
16891685
},
16901686
},

packages/react-grab/src/components/toolbar/index.tsx

Lines changed: 2 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1299,24 +1299,14 @@ export const Toolbar: Component<ToolbarProps> = (props) => {
12991299
</span>
13001300
</Show>
13011301
<Show when={selectionHintIndex() === 1}>
1302-
<span
1303-
class={cn(
1304-
"flex items-center gap-1",
1305-
HINT_FLIP_IN_ANIMATION,
1306-
)}
1307-
>
1302+
<span class={cn("flex items-center gap-1", HINT_FLIP_IN_ANIMATION)}>
13081303
<Kbd></Kbd>
13091304
<Kbd></Kbd>
13101305
to fine-tune target
13111306
</span>
13121307
</Show>
13131308
<Show when={selectionHintIndex() === 2}>
1314-
<span
1315-
class={cn(
1316-
"flex items-center gap-1",
1317-
HINT_FLIP_IN_ANIMATION,
1318-
)}
1319-
>
1309+
<span class={cn("flex items-center gap-1", HINT_FLIP_IN_ANIMATION)}>
13201310
<Kbd>esc</Kbd>
13211311
to cancel
13221312
</span>

packages/react-grab/src/components/toolbar/toolbar-content.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -216,10 +216,12 @@ export const ToolbarContent: Component<ToolbarContentProps> = (props) => {
216216
"grid relative overflow-visible",
217217
gridSizeTransitionClass(),
218218
props.isCollapsed
219-
? (isVertical()
220-
? "grid-rows-[0fr] pointer-events-none"
221-
: "grid-cols-[0fr] pointer-events-none")
222-
: (isVertical() ? "grid-rows-[1fr]" : "grid-cols-[1fr]"),
219+
? isVertical()
220+
? "grid-rows-[0fr] pointer-events-none"
221+
: "grid-cols-[0fr] pointer-events-none"
222+
: isVertical()
223+
? "grid-rows-[1fr]"
224+
: "grid-cols-[1fr]",
223225
)}
224226
>
225227
<div

packages/react-grab/src/utils/comment-storage.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,7 @@ let didConfirmClear = readSessionFlag(CLEAR_CONFIRMED_KEY);
7676

7777
export const loadComments = (): CommentItem[] => commentItems;
7878

79-
export const addCommentItem = (
80-
item: Omit<CommentItem, "id">,
81-
): CommentItem[] =>
79+
export const addCommentItem = (item: Omit<CommentItem, "id">): CommentItem[] =>
8280
persistCommentItems(
8381
[{ ...item, id: generateId("comment") }, ...commentItems].slice(
8482
0,
@@ -101,6 +99,9 @@ export const confirmClear = (): void => {
10199
sessionStorage.setItem(CLEAR_CONFIRMED_KEY, "1");
102100
} catch (error) {
103101
// HACK: sessionStorage can throw in private browsing or when quota is exceeded
104-
logRecoverableError("Failed to save clear preference to sessionStorage", error);
102+
logRecoverableError(
103+
"Failed to save clear preference to sessionStorage",
104+
error,
105+
);
105106
}
106107
};

packages/website/next.config.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,9 @@ const nextConfig: NextConfig = {
55
// HACK: disable react compiler to avoid issues with source mangling
66
reactCompiler: false,
77
productionBrowserSourceMaps: true,
8-
turbopack: {},
8+
turbopack: {
9+
root: "../..",
10+
},
911
experimental: {
1012
optimizeCss: true,
1113
inlineCss: true,

0 commit comments

Comments
 (0)