[Question] PR on new glyphs?

[tamcy]

My I know if pull request(s) on adding new glyphs be reviewed and accepted when appropriate?

I'd like to submit a PR on glyph changes/additions to the repo, but I couldn't find any precedent, hence the question.

I'll throw all my questions here, you can ignore them if the answer is no.

First off, development was done using scripts and FontForge. It worked as the changes are fairly minimal, all new glyphs are created from existing ones. Due to the lack of a full-blown font editor I will not be able to perform fine tuning.

If PR is ok and you don't mind fine tuning after merge, here are some details and questions on my planned submission.

---

1. Add ibreve & Ibreve

Attempt to resolve #85.

This should be easy to review and merge. Just one question in advance: I suppose only new glyphs in Master/ are needed? (I may not be able to provide a useful PR if Instances/ glyphs are also needed)

---

2. Add verticallineabovecmb & verticallineabovecmb.cap

Together with the next change, attempt to resolve #40 .

Feature files have to be updated for this one. Hence the question: I understand the need to update master feature files, but what about those in the non-master instances?

---

3. Add dotaboverightcmb & dotaboverightcmb.cap for "o" and "O"

This involves 3 changes:

1. Add two new glyphs.
2. Add a aboverightLC or aboverightUC anchor to o and O respectively.
3. Add mark anchors to the feature files.

I believe this will need tuning after merge. Again, what about feature files in the non-master instances? If a pull request is to be submitted do I need to prepare an interpolated coordinates of the mark position?

Finally, which branch should the pull request be created upon? I'd prefer post-4.005-fixes, but I don't have some full-blown font editor and the build VF command doesn't work in this dev branch so I can't really test my changes locally.

[frankrolf]

If you want to add new glyphs, a drawing will be needed in all 18 master UFOs (Roman and Italic).
Features and kerning related to the change will be required as well. In many cases, this just means adding the new glyph to an existing kerning group.

The instances are built using makeinstancesufo, which takes care of the interpolation of all UFO data. Then, features respective of a given instance can be built using kernfeaturewriter and markfeaturewriter modules.

In other words:

• changes ① and ②: trivial – just add the slot and use existing outlines.
• change ③: this needs to arrive at a more pleasing result – the placement of the dotaboveright needs to be consistent and not leave a gap toward the preceding accent. Also, we would need to look into how to handle kerning after combining marks (as of now, combining marks are ignored in the kerning – see kern feature needs lookupflag source-sans#167)

Do you have examples of fonts doing ③ well?

The current dev branch is post-4.005-fixes – since glyphs are not simultaneously added to all sources, it’s not possible to build a VF there at the moment. You can still build static fonts for testing though, using makeotf.