Add flake8-django in ruff config for code validation

Signed-off-by: tdruez <[email protected]>

Author: tdruez

pyproject.toml

@@ -164,6 +164,7 @@ select = [
     "D",  # pydocstyle
     "F",  # Pyflakes
     "UP", # pyupgrade
+    "DJ", # flake8-django
     "S",  # flake8-bandit
     "I",  # isort
     "C9", # McCabe complexity

scanpipe/models.py

@@ -431,6 +431,9 @@ class ExtraDataFieldMixin(models.Model):
         help_text=_("Optional mapping of extra data key/values."),
     )
 
+    class Meta:
+        abstract = True
+
     def update_extra_data(self, data):
         """Update the `extra_data` field with the provided `data` dict."""
         if not isinstance(data, dict):
@@ -439,9 +442,6 @@ def update_extra_data(self, data):
         self.extra_data.update(data)
         self.save(update_fields=["extra_data"])
 
-    class Meta:
-        abstract = True
-
 
 class UpdateMixin:
     """
@@ -635,6 +635,10 @@ def save(self, *args, **kwargs):
         if global_webhook and is_new and not is_clone and not skip_global_webhook:
             self.setup_global_webhook()
 
+    def get_absolute_url(self):
+        """Return this project's details URL."""
+        return reverse("project_detail", args=[self.slug])
+
     def setup_global_webhook(self):
         """
         Create a global webhook subscription instance from values defined in the
@@ -1428,10 +1432,6 @@ def add_error(
             object_instance,
         )
 
-    def get_absolute_url(self):
-        """Return this project's details URL."""
-        return reverse("project_detail", args=[self.slug])
-
     @cached_property
     def resource_count(self):
         """Return the number of resources related to this project."""
@@ -2533,21 +2533,6 @@ class Compliance(models.TextChoices):
     class Meta:
         abstract = True
 
-    @classmethod
-    def from_db(cls, db, field_names, values):
-        """
-        Store the ``license_expression_field`` on loading this instance from the
-        database value.
-        The cached value is then used to detect changes on `save()`.
-        """
-        new = super().from_db(db, field_names, values)
-
-        if cls.license_expression_field in field_names:
-            field_index = field_names.index(cls.license_expression_field)
-            new._loaded_license_expression = values[field_index]
-
-        return new
-
     def save(self, codebase=None, *args, **kwargs):
         """
         Injects policies, if the feature is enabled, when the
@@ -2566,6 +2551,21 @@ def save(self, codebase=None, *args, **kwargs):
 
         super().save(*args, **kwargs)
 
+    @classmethod
+    def from_db(cls, db, field_names, values):
+        """
+        Store the ``license_expression_field`` on loading this instance from the
+        database value.
+        The cached value is then used to detect changes on `save()`.
+        """
+        new = super().from_db(db, field_names, values)
+
+        if cls.license_expression_field in field_names:
+            field_index = field_names.index(cls.license_expression_field)
+            new._loaded_license_expression = values[field_index]
+
+        return new
+
     @property
     def policy_index(self):
         return self.project.policy_index
@@ -2790,6 +2790,9 @@ class Meta:
     def __str__(self):
         return self.path
 
+    def get_absolute_url(self):
+        return reverse("resource_detail", args=[self.project.slug, self.path])
+
     @property
     def location_path(self):
         """Return the location of the resource as a Path instance."""
@@ -2949,9 +2952,6 @@ def extracted_from(self, codebase=None):
             archive_path, _, _ = self.path.rpartition("-extract")
             return self.project.get_resource(archive_path)
 
-    def get_absolute_url(self):
-        return reverse("resource_detail", args=[self.project.slug, self.path])
-
     def get_raw_url(self):
         """Return the URL to access the RAW content of the resource."""
         return reverse("resource_raw", args=[self.project.slug, self.path])
@@ -3143,14 +3143,14 @@ class VulnerabilityMixin(models.Model):
 
     affected_by_vulnerabilities = models.JSONField(blank=True, default=list)
 
+    class Meta:
+        abstract = True
+
     @property
     def is_vulnerable(self):
         """Returns True if this instance is affected by vulnerabilities."""
         return bool(self.affected_by_vulnerabilities)
 
-    class Meta:
-        abstract = True
-
 
 class VulnerabilityQuerySetMixin:
     def vulnerable(self):