Add "(No value detected)" for Copyright and Holder charts #1697

Signed-off-by: tdruez <tdruez@nexb.com>

Author: tdruez

CHANGELOG.rst

@@ -26,6 +26,9 @@ v34.12.0 (unreleased)
   Refine the CSS for the Resource viewer.
   https://github.com/aboutcode-org/scancode.io/pull/1692
 
+- Add "(No value detected)" for Copyright and Holder charts.
+  https://github.com/aboutcode-org/scancode.io/issues/1697
+
 v34.11.0 (2025-05-02)
 ---------------------
 

scanpipe/tests/__init__.py

@@ -48,12 +48,16 @@
 mocked_now = mock.Mock(now=lambda: datetime(2010, 10, 10, 10, 10, 10))
 
 
+def make_string(length):
+    return str(uuid.uuid4())[:length]
+
+
 def make_project(name=None, **data):
     """
     Create and return a Project instance.
     Labels can be provided using the labels=["labels1", "labels2"] argument.
     """
-    name = name or str(uuid.uuid4())[:8]
+    name = name or make_string(8)
     pipelines = data.pop("pipelines", [])
     labels = data.pop("labels", [])
 
@@ -68,26 +72,35 @@ def make_project(name=None, **data):
     return project
 
 
-def make_resource_file(project, path, **data):
+def make_resource(project, path, **data):
     return CodebaseResource.objects.create(
         project=project,
         path=path,
         name=path.split("/")[-1],
+        tag=path.split("/")[0],
+        **data,
+    )
+
+
+def make_resource_file(project, path=None, **data):
+    if path is None:  # Empty string is allowed as path
+        path = make_string(5)
+
+    return make_resource(
+        project=project,
+        path=path,
         extension="." + path.split(".")[-1],
         type=CodebaseResource.Type.FILE,
         is_text=True,
-        tag=path.split("/")[0],
         **data,
     )
 
 
 def make_resource_directory(project, path, **data):
-    return CodebaseResource.objects.create(
+    return make_resource(
         project=project,
         path=path,
-        name=path.split("/")[-1],
         type=CodebaseResource.Type.DIRECTORY,
-        tag=path.split("/")[0],
         **data,
     )
 
@@ -105,7 +118,7 @@ def make_dependency(project, **data):
 
 def make_message(project, **data):
     if "model" not in data:
-        data["model"] = str(uuid.uuid4())[:8]
+        data["model"] = make_string(8)
 
     if "severity" not in data:
         data["severity"] = ProjectMessage.Severity.ERROR

scanpipe/tests/pipes/test_d2d.py

@@ -193,7 +193,9 @@ def test_scanpipe_pipes_d2d_match_purldb_resources(self, mock_match_package):
             self.assertEqual(package, resource.discovered_packages.get())
 
     @mock.patch("scanpipe.pipes.purldb.request_get")
-    def test_scanpipe_pipes_d2d_match_purldb_directories(self, mock_request_get):
+    def test_scanpipe_pipes_d2d_match_purldb_directories(
+        self, mock_request_get: object
+    ) -> object:
         to_1 = make_resource_directory(
             self.project1,
             "to/package.jar-extract",

scanpipe/tests/test_views.py

@@ -491,30 +491,21 @@ def test_scanpipe_views_project_details_charts_view(self):
         self.assertNotContains(response, 'id="dependency-charts"')
         self.assertNotContains(response, 'id="resource-charts-charts"')
 
-        CodebaseResource.objects.create(
-            project=self.project1,
-            programming_language="Python",
-            type=CodebaseResource.Type.FILE,
-        )
+        make_resource_file(self.project1, path="", programming_language="Python")
 
         with self.assertNumQueries(12):
             response = self.client.get(url)
         self.assertContains(response, '{"Python": 1}')
 
     def test_scanpipe_views_project_details_charts_compliance_alert(self):
         url = reverse("project_charts", args=[self.project1.slug])
+        resource = make_resource_file(self.project1)
         expected = 'id="compliance_alert_chart"'
 
         response = self.client.get(url)
         self.assertNotContains(response, expected)
 
-        response = self.client.get(url)
-        self.assertNotContains(response, expected)
-
-        resource = CodebaseResource.objects.create(
-            project=self.project1,
-            type=CodebaseResource.Type.FILE,
-        )
+        # Do not trigger the save() logic.
         CodebaseResource.objects.filter(id=resource.id).update(
             compliance_alert=CodebaseResource.Compliance.ERROR
         )
@@ -523,6 +514,27 @@ def test_scanpipe_views_project_details_charts_compliance_alert(self):
         self.assertContains(response, expected)
         self.assertContains(response, '{"error": 1}')
 
+    def test_scanpipe_views_project_details_charts_copyrights(self):
+        url = reverse("project_charts", args=[self.project1.slug])
+
+        make_resource_file(self.project1)
+        copyrights = [
+            {
+                "copyright": "Copyright (c) nexB Inc. and others",
+                "start_line": 2,
+                "end_line": 2,
+            }
+        ]
+        make_resource_file(self.project1, copyrights=copyrights)
+
+        response = self.client.get(url)
+        expected = (
+            '<script id="file_copyrights" type="application/json">'
+            '{"Copyright (c) nexB Inc. and others": 1, "(No value detected)": 1}'
+            "</script>"
+        )
+        self.assertContains(response, expected)
+
     def test_scanpipe_views_project_details_scan_summary_panels(self):
         url = self.project1.get_absolute_url()
 
@@ -1089,18 +1101,8 @@ def test_scanpipe_views_codebase_relation_diff_view(self):
             self.data / "codebase" / "b.txt",
         ]
         copy_inputs(resource_files, self.project1.codebase_path)
-        resource1 = CodebaseResource.objects.create(
-            project=self.project1,
-            path="a.txt",
-            type=CodebaseResource.Type.FILE,
-            is_text=True,
-        )
-        resource2 = CodebaseResource.objects.create(
-            project=self.project1,
-            path="b.txt",
-            type=CodebaseResource.Type.FILE,
-            is_text=True,
-        )
+        resource1 = make_resource_file(self.project1, path="a.txt")
+        resource2 = make_resource_file(self.project1, path="b.txt")
         data = {
             "from_path": resource1.path,
             "to_path": resource2.path,

scanpipe/views.py

@@ -1029,10 +1029,9 @@ def get_context_data(self, **kwargs):
             for field_name in fields:
                 if field_name in ["holders", "copyrights"]:
                     field_values = (
-                        data.get(field_name[:-1])
+                        data.get(field_name[:-1]) if isinstance(data, dict) else ""
                         for entry in qs_values
-                        for data in entry.get(field_name, [])
-                        if isinstance(data, dict)
+                        for data in (entry.get(field_name, []) or [""])
                     )
                 else:
                     field_values = (entry[field_name] for entry in qs_values)