Fix failing tests #1524

Signed-off-by: tdruez <tdruez@nexb.com>

Author: tdruez

scanpipe/forms.py

@@ -322,9 +322,7 @@ def get_queryset(self):
                 CodebaseRelation.objects.select_related("from_resource", "to_resource")
             ),
             "projectmessage": ProjectMessage.objects.all(),
-            "todos": (
-                CodebaseResource.objects.files().status(flag.REQUIRES_REVIEW)
-            ),
+            "todos": CodebaseResource.objects.files().status(flag.REQUIRES_REVIEW),
         }
 
         return querysets.get(self.cleaned_data["model_name"])

scanpipe/pipes/output.py

@@ -493,7 +493,7 @@ def to_xlsx(project):
             _add_xlsx_worksheet(workbook, "LAYERS", layers_data, docker.layer_fields)
 
         todos_queryset = get_queryset(project, "todos")
-        if todos_queryset.exists():
+        if todos_queryset:
             queryset_to_xlsx_worksheet(
                 todos_queryset, workbook, exclude_fields, worksheet_name="TODOS"
             )

scanpipe/tests/pipes/test_output.py

@@ -222,7 +222,7 @@ def test_scanpipe_pipes_outputs_to_xlsx(self):
 
         # Make sure the output can be generated even if the work_directory was wiped
         shutil.rmtree(project.work_directory)
-        with self.assertNumQueries(9):
+        with self.assertNumQueries(10):
             output_file = output.to_xlsx(project=project)
         self.assertIn(output_file.name, project.output_root)
 
@@ -497,34 +497,6 @@ def test_scanpipe_pipes_outputs_to_attribution(self):
         output_file = output.to_attribution(project=project)
         self.assertEqual("EMPTY_TEMPLATE", output_file.read_text())
 
-    def test_scanpipe_pipes_outputs_get_todos_data(self):
-        project = Project.objects.create(name="Analysis")
-        todos_data = output.get_todos_data(project)
-        self.assertEqual([], list(todos_data))
-
-        make_resource_file(
-            project=project, path="path/file1.ext", status=flag.REQUIRES_REVIEW
-        )
-        make_resource_file(project=project, path="path/file2.ext")
-
-        todos_data = output.get_todos_data(project)
-        expected = [
-            {
-                "path": "path/file1.ext",
-                "status": "requires-review",
-                "size": None,
-                "name": "file1.ext",
-                "extension": ".ext",
-                "programming_language": "",
-                "mime_type": "",
-                "tag": "path",
-                "detected_license_expression": "",
-                "compliance_alert": "",
-                "project__name": "Analysis",
-            }
-        ]
-        self.assertEqual(expected, list(todos_data))
-
 
 class ScanPipeXLSXOutputPipesTest(TestCase):
     def test__add_xlsx_worksheet_does_truncates_long_strings_over_max_len(self):