refactore data request

Author: abbasihamed

lib/injection.dart

@@ -1,10 +1,10 @@
 import 'package:get_it/get_it.dart';
 import 'package:weather_mvvm/src/data/weather_api.dart';
-import 'package:weather_mvvm/src/logic/current_location.dart';
+import 'package:weather_mvvm/src/logic/location_manager.dart';
 
 var injection = GetIt.I;
 
 void setup() {
   injection.registerLazySingleton(() => WeatherServices());
-  injection.registerSingleton(CurrentLocation());
+  injection.registerSingleton(LocationManager());
 }

lib/src/data/http_managment.dart

@@ -0,0 +1,27 @@
+import 'dart:io';
+
+import 'package:http/http.dart' as http;
+import 'package:weather_mvvm/src/data/api_state.dart';
+
+class HttpManager {
+  static Future requestManager(String url) async {
+    try {
+      var response = await http.get(Uri.parse(url));
+      if (response.statusCode == 200) {
+        return response;
+      }
+      if (response.statusCode == 404) {
+        return Failure(code: 404, failureResponse: 'City Not Fount');
+      }
+      return Failure(code: 100, failureResponse: 'Invalid Response');
+    } on HttpException {
+      return Failure(code: 101, failureResponse: 'No Internet');
+    } on FormatException {
+      return Failure(code: 102, failureResponse: 'Invalid Format');
+    } on SocketException {
+      return Failure(code: 102, failureResponse: 'No Internet Connection');
+    } catch (e) {
+      return Failure(code: 103, failureResponse: 'Unknown Error');
+    }
+  }
+}

lib/src/data/weather_api.dart

@@ -2,57 +2,32 @@ import 'dart:io';
 
 import 'package:http/http.dart' as http;
 import 'package:weather_mvvm/src/data/api_state.dart';
+import 'package:weather_mvvm/src/data/http_managment.dart';
 import 'package:weather_mvvm/src/models/weather_models.dart';
 import 'package:weather_mvvm/src/utils/constans.dart';
 
 class WeatherServices {
   Future getCurrentWeather(String lat, String long) async {
-    try {
-      var response = await http.get(Uri.parse(
-          'https://api.openweathermap.org/data/2.5/weather?lat=$lat&lon=$long&appid=$apiKey'));
-      if (response.statusCode == 200) {
-        return Success(
-            code: 200, successResponse: weatherModelFromJson(response.body));
-      }
-      if (response.statusCode == 404) {
-        return Failure(code: 404, failureResponse: 'City Not Fount');
-      }
-      return Failure(code: 100, failureResponse: 'Invalid Response');
-    } on HttpException {
-      return Failure(code: 101, failureResponse: 'No Internet');
-    } on FormatException {
-      return Failure(code: 102, failureResponse: 'Invalid Format');
-    } on SocketException {
-      return Failure(code: 102, failureResponse: 'No Internet Connection');
-    } catch (e) {
-      return Failure(code: 103, failureResponse: 'Unknown Error');
+    var response = await HttpManager.requestManager(
+        'https://api.openweathermap.org/data/2.5/weather?lat=$lat&lon=$long&appid=$apiKey');
+    if (response is http.Response) {
+      return Success(
+          code: 200, successResponse: weatherModelFromJson(response.body));
+    }
+    if (response is Failure) {
+      return response;
     }
   }
 
   Future getWeather({required String cityName}) async {
-    try {
-      var response = await http.get(
-        Uri.parse(
-            'https://api.openweathermap.org/data/2.5/weather?q=$cityName&appid=$apiKey'),
-      );
-      if (response.statusCode == 200) {
-        return Success(
-          code: 200,
-          successResponse: weatherModelFromJson(response.body),
-        );
-      }
-      if (response.statusCode == 404) {
-        return Failure(code: 404, failureResponse: 'City Not Fount');
-      }
-      return Failure(code: 100, failureResponse: 'Invalid Response');
-    } on HttpException {
-      return Failure(code: 101, failureResponse: 'No Internet');
-    } on FormatException {
-      return Failure(code: 102, failureResponse: 'Invalid Format');
-    } on SocketException {
-      return Failure(code: 102, failureResponse: 'No Internet Connection');
-    } catch (e) {
-      return Failure(code: 103, failureResponse: 'Unknown Error');
+    var response = await HttpManager.requestManager(
+        'https://api.openweathermap.org/data/2.5/weather?q=$cityName&appid=$apiKey');
+    if (response is http.Response) {
+      return Success(
+          code: 200, successResponse: weatherModelFromJson(response.body));
+    }
+    if (response is Failure) {
+      return response;
     }
   }
 }

lib/src/logic/current_location.dart lib/src/logic/location_manager.dartlib/src/logic/current_location.dart renamed to lib/src/logic/location_manager.dart

@@ -1,6 +1,6 @@
 import 'package:location/location.dart';
 
-class CurrentLocation {
+class LocationManager {
   Location location = Location();
   LocationData? _locationData;
 

lib/src/view_model/weather_view_model.dart

@@ -4,14 +4,14 @@ import 'package:weather_mvvm/injection.dart';
 import 'package:weather_mvvm/src/data/api_state.dart';
 import 'package:weather_mvvm/src/data/weather_api.dart';
 import 'package:weather_mvvm/src/logic/background_controller.dart';
-import 'package:weather_mvvm/src/logic/current_location.dart';
+import 'package:weather_mvvm/src/logic/location_manager.dart';
 import 'package:weather_mvvm/src/logic/validation.dart';
 import 'package:weather_mvvm/src/models/error_models.dart';
 import 'package:weather_mvvm/src/models/weather_models.dart';
 import 'package:weather_mvvm/src/utils/constans.dart';
 
 class WeatherViewModel extends GetxController {
-  final loc = injection.get<CurrentLocation>();
+  final loc = injection.get<LocationManager>();
   late WeatherModel _weatherModel;
   ErrorServices? _errorServices;
   bool _loading = true;

lib/src/views/home_screen.dart

@@ -5,7 +5,7 @@ import 'package:weather_mvvm/src/components/app_loading.dart';
 import 'package:weather_mvvm/src/components/app_textfield.dart';
 import 'package:weather_mvvm/src/components/background.dart';
 import 'package:weather_mvvm/src/logic/background_controller.dart';
-import 'package:weather_mvvm/src/logic/current_location.dart';
+import 'package:weather_mvvm/src/logic/location_manager.dart';
 import 'package:weather_mvvm/src/logic/get_image.dart';
 import 'package:weather_mvvm/src/logic/to_celsius.dart';
 import 'package:weather_mvvm/src/utils/constans.dart';