PR for review#3
Open
aashutoshPanda wants to merge 37 commits into
Open
Conversation
feat: Add implementation of APIs
Improvements
| import sequelize from "../helpers/sequelize.js"; | ||
| import { DataTypes } from "sequelize"; | ||
|
|
||
| const AudioSystem = sequelize.define("AudioSystem", { |
There was a problem hiding this comment.
Is Audio-system is required in a separate table? There are going to be fixed number of audio-system. Could have been a column in shows table.
| */ | ||
| export const getSeats = async (req, res) => { | ||
| try { | ||
| const showId = req.params.id; |
There was a problem hiding this comment.
check for undefined values before hitting the database. It's best practice to reduce database errors by validating values beforehand.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for the sake of adding comments.