Skip to content

Commit 96c6a97

Browse files
committed
Resolve some of the warnings in Windows build
This is a preparation compile with `/WX` flag.
1 parent e72ea3e commit 96c6a97

File tree

5 files changed

+22673
-5
lines changed

5 files changed

+22673
-5
lines changed

include/CXXGraph/Graph/IO/InputOperation_impl.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -367,7 +367,7 @@ int Graph<T>::readFromBinary(const std::string &filepath, bool readNodeFeatures,
367367
in.close();
368368
return 0;
369369

370-
} catch (const std::exception &e) {
370+
} catch (const std::exception &) {
371371
in.close();
372372
return -4;
373373
}

include/CXXGraph/Graph/IO/OutputOperation_impl.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ int Graph<T>::writeToBinary(const std::string &filepath, bool writeNodeFeatures,
282282
out.close();
283283
return 0;
284284

285-
} catch (const std::exception &e) {
285+
} catch (const std::exception &) {
286286
out.close();
287287
return -2;
288288
}

test/KahnTest.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ TEST(KahnTest, correct_example_small) {
9292
ASSERT_TRUE(res.errorMessage.empty());
9393
ASSERT_EQ(res.nodesInTopoOrder.size(), graph.getNodeSet().size());
9494

95-
std::unordered_map<CXXGraph::id_t, int> topOrderNodeIds;
95+
std::unordered_map<CXXGraph::id_t, size_t> topOrderNodeIds;
9696
for (size_t i = 0; i < res.nodesInTopoOrder.size(); ++i) {
9797
topOrderNodeIds[res.nodesInTopoOrder[i].getId()] = i;
9898
}
@@ -161,7 +161,7 @@ TEST(KahnTest, correct_example_big) {
161161
ASSERT_TRUE(res.errorMessage.empty());
162162
ASSERT_EQ(res.nodesInTopoOrder.size(), graph.getNodeSet().size());
163163

164-
std::unordered_map<CXXGraph::id_t, int> topOrderNodeIds;
164+
std::unordered_map<CXXGraph::id_t, size_t> topOrderNodeIds;
165165
for (size_t i = 0; i < res.nodesInTopoOrder.size(); ++i) {
166166
topOrderNodeIds[res.nodesInTopoOrder[i].getId()] = i;
167167
}

test/TopologicalSortTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ TEST(TopologicalSortTest, test_3) {
9696
ASSERT_EQ(res.nodesInTopoOrder.size(), 8);
9797

9898
// check topological order of nodes
99-
std::unordered_map<CXXGraph::id_t, int> nodeToOrder;
99+
std::unordered_map<CXXGraph::id_t, size_t> nodeToOrder;
100100
for (size_t i = 0; i < res.nodesInTopoOrder.size(); ++i) {
101101
nodeToOrder[res.nodesInTopoOrder[i].getId()] = i;
102102
}

0 commit comments

Comments
 (0)