Skip to content

Commit 1e6b0ce

Browse files
#449 add explicit to node constructor (#484)
* Changes defines in include guards to avoid undefined behaviour * Adds Explicit constructor to Node class (#449) * Update cmake.yml to run tests --------- Co-authored-by: Olek Raymond <olek.raymond@riskaware.co.uk>
1 parent 985625e commit 1e6b0ce

2 files changed

Lines changed: 1 addition & 3 deletions

File tree

.github/workflows/cmake.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,7 @@ name: CMake
22

33
on:
44
push:
5-
branches: [ master ]
65
pull_request:
7-
branches: [ master ]
86

97
env:
108
# Customize the CMake build type here (Release, Debug, RelWithDebInfo, etc.)

include/CXXGraph/Node/Node_decl.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class Node {
4343

4444
Node(const std::string &, const T &data);
4545
// Move constructor
46-
Node(const std::string &, T &&data) noexcept;
46+
explicit Node(const std::string &, T &&data) noexcept;
4747
~Node() = default;
4848
const CXXGraph::id_t &getId() const;
4949
const std::string &getUserId() const;

0 commit comments

Comments
 (0)