Skip to content

Remove Default impls with unimplemented! #1

@conradoplg

Description

@conradoplg

Using DefaultIsZeroes requires us to implement Default on SpendAuth and Binding, but those are supposed to be unconstructable. This was solved by adding a Default impl which calls unimplemented! but that doesn't seem ideal.

Check for an alternative and remove the Default impls. One possibility is to explicitly implement Zeroize and Drop. See https://github.com/ZcashFoundation/redjubjub/pull/87/files#r628834530 and ZcashFoundation/redjubjub@2745d37 for context.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions