Conversation
Remove premium add-on upsell notices (Premium, WooCommerce SEO, Local SEO) from the FTC wizard while preserving the UI styling improvements. Co-Authored-By: Claude Opus 4.6 (1M context) <[email protected]>
Pull Request Test Coverage Report for Build ed2beeb6bbce57a7aa41a986ab52246493db5032Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The first-time configuration wizard contains upsell notices for premium add-ons (Yoast SEO Premium, WooCommerce SEO, Local SEO) that were introduced in #22688. These need to be removed as part of Yoast/reserved-tasks#1135.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
UpsellNoticecomponent, upsell JSX blocks, supporting PHP data (isWooCommerceActive,isWooCommerceSeoActive,Woocommerce_Helper), upsell shortlinks, and thestateprop that was threaded toIndexationStep/FinishStepsolely for upsell gating.safeCreateInterpolateElementusage) are intentionally preserved.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
/wp-admin/admin.php?page=wpseo_dashboard#/first-time-configuration).Relevant test scenarios
To properly test step 4, you need two environments:
Test instructions for QA when the code is in the RC
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
Other environments
Documentation
Quality assurance
grunt build:imagesand committed the results, if my PR introduces new images or SVGs.Innovation
Fixes Yoast/reserved-tasks#1135