Skip to content

Commit 95d1c8d

Browse files
committed
[NDGL-63] chore: 코드래빗 리뷰 반영
- TODO 주석 달기 - 방어적으로 코드 짜기 - TimelineContent - 로직 잘못 설정한 부분 수정 - PlaceInfoTab
1 parent ecc1331 commit 95d1c8d

6 files changed

Lines changed: 6 additions & 4 deletions

File tree

core/ui/src/main/java/com/yapp/ndgl/core/ui/util/WebUtil.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,6 @@ fun Context.launchBrowser(url: String) {
1010
val intent = Intent(Intent.ACTION_VIEW, url.toUri())
1111
startActivity(intent)
1212
} catch (e: Exception) {
13-
Timber.e("Failed to launch browser: $url")
13+
Timber.e("Failed to launch browser: $url, exception: $e")
1414
}
1515
}

feature/travel/src/main/java/com/yapp/ndgl/feature/travel/placedetail/PlaceDetailScreen.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,7 @@ private fun PlaceDetailScreen(
178178
Text(
179179
text = buildAnnotatedString {
180180
withStyle(style = SpanStyle(color = NDGLTheme.colors.black500)) {
181+
// TODO: API 응답이 정해지면 하드코딩 제거
181182
append("식당 • $20~40 • 리뷰 ${placeInfo.rating}")
182183
}
183184
withStyle(style = SpanStyle(color = NDGLTheme.colors.black200)) {

feature/travel/src/main/java/com/yapp/ndgl/feature/travel/placedetail/PlaceDetailViewModel.kt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -98,6 +98,7 @@ class PlaceDetailViewModel @AssistedInject constructor(
9898
reduce { copy(selectedAlternativePlace = alternativePlace, showChangeModal = true) }
9999
}
100100

101+
// TODO("Plan B 장소 변경 로직")
101102
private fun confirmChangePlace() {
102103
reduce {
103104
copy(

feature/travel/src/main/java/com/yapp/ndgl/feature/travel/placedetail/component/PlaceInfoTab.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -95,7 +95,7 @@ internal fun PlaceInfoTab(
9595
modifier = Modifier
9696
.fillMaxWidth()
9797
.noRippleClickable {
98-
clickAddress()
98+
clickMenu()
9999
},
100100
horizontalArrangement = Arrangement.spacedBy(8.dp),
101101
) {

feature/travel/src/main/java/com/yapp/ndgl/feature/travel/traveldetail/TravelDetailViewModel.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,7 @@ class TravelDetailViewModel @AssistedInject constructor(
323323
itinerary
324324
}
325325
}
326-
val totalDuration = itineraries.getOrNull(dayIndex)?.totalDuration ?: 0.hours
326+
val totalDuration = updatedItineraries.getOrNull(dayIndex)?.totalDuration ?: 0.hours
327327

328328
copy(
329329
startTime = startTime,

feature/travel/src/main/java/com/yapp/ndgl/feature/travel/traveldetail/component/TimelineContent.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ internal fun TimelineContent(
6060
) {
6161
var isSettingStartTime by remember { mutableStateOf(false) }
6262
var selectedStartTime by remember { mutableStateOf(startTime) }
63-
val previewEndTime by remember(selectedStartTime) { derivedStateOf { selectedStartTime + totalDuration } }
63+
val previewEndTime by remember(selectedStartTime, totalDuration) { derivedStateOf { selectedStartTime + totalDuration } }
6464

6565
Column(
6666
modifier = Modifier

0 commit comments

Comments
 (0)