Skip to content

Commit 8fc085b

Browse files
committed
[NDGL-89] chore: 내 여행 탭 컴포넌트에서 하드 코딩된 string 제거
1 parent 761bc0f commit 8fc085b

File tree

3 files changed

+10
-5
lines changed

3 files changed

+10
-5
lines changed

feature/travel/src/main/java/com/yapp/ndgl/feature/travel/mytravel/RecommendedTravelSection.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ internal fun RecommendedTravelSection(
5050
verticalArrangement = Arrangement.spacedBy(24.dp),
5151
) {
5252
Text(
53-
text = "추천하는 따라가기 여행",
53+
text = stringResource(R.string.my_travel_recommended_travel_header),
5454
style = NDGLTheme.typography.subtitleLgSemiBold,
5555
color = NDGLTheme.colors.black900,
5656
modifier = Modifier.padding(horizontal = 24.dp),

feature/travel/src/main/java/com/yapp/ndgl/feature/travel/mytravel/UpcomingTravelListSection.kt

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ internal fun UpcomingTravelListSection(
6767
@Composable
6868
private fun Header() {
6969
Text(
70-
text = "다가오는 여행",
70+
text = stringResource(R.string.my_travel_upcoming_list_header),
7171
modifier = Modifier.padding(horizontal = 24.dp),
7272
color = NDGLTheme.colors.black700,
7373
style = NDGLTheme.typography.subtitleLgSemiBold,
@@ -173,13 +173,13 @@ private fun EmptyTravel(
173173
modifier = Modifier.size(100.dp),
174174
)
175175
Text(
176-
text = "아직 예정된 여행이 없어요.",
176+
text = stringResource(R.string.my_travel_upcoming_list_empty_title),
177177
modifier = Modifier.padding(top = 16.dp),
178178
color = NDGLTheme.colors.black500,
179179
style = NDGLTheme.typography.subtitleMdSemiBold,
180180
)
181181
Text(
182-
text = "따라가기 영상을 담아두면 여행 준비가 쉬워져요.",
182+
text = stringResource(R.string.my_travel_upcoming_list_empty_description),
183183
modifier = Modifier.padding(top = 4.dp),
184184
color = NDGLTheme.colors.black400,
185185
style = NDGLTheme.typography.bodyLgRegular,
@@ -207,7 +207,7 @@ private fun FindNewTravelCtaButton(
207207
verticalAlignment = Alignment.CenterVertically,
208208
) {
209209
Text(
210-
text = "새로운 여행지 찾아보기",
210+
text = stringResource(R.string.my_travel_upcoming_list_find_new_travel),
211211
color = NDGLTheme.colors.black800,
212212
style = NDGLTheme.typography.bodyMdSemiBold,
213213
)

feature/travel/src/main/res/values/strings.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,16 @@
1010
<string name="my_travel_upcoming_travel_d_day_plus">D+%d</string>
1111

1212
<!-- Upcoming Travel List Section -->
13+
<string name="my_travel_upcoming_list_header">다가오는 여행</string>
1314
<string name="my_travel_upcoming_list_date_format">M월 d일</string>
1415
<string name="my_travel_upcoming_list_travel_duration">%s~%s</string>
1516
<string name="my_travel_upcoming_list_d_day_minus">D%d</string>
1617
<string name="my_travel_upcoming_list_d_day_plus">D+%d</string>
18+
<string name="my_travel_upcoming_list_empty_title">아직 예정된 여행이 없어요.</string>
19+
<string name="my_travel_upcoming_list_empty_description">따라가기 영상을 담아두면 여행 준비가 쉬워져요.</string>
20+
<string name="my_travel_upcoming_list_find_new_travel">새로운 여행지 찾아보기</string>
1721

1822
<!-- Recommended Travel Section -->
23+
<string name="my_travel_recommended_travel_header">추천하는 따라가기 여행</string>
1924
<string name="my_travel_recommended_travel_nights_days">%1$d박 %2$d일</string>
2025
</resources>

0 commit comments

Comments
 (0)