Memory Leak

[goncalodelima]

I typed /spark heap dump with only 6 players online, but I have 32 craftplayer instances because of huskhomes

This is a serious problem since I have one world per player; and because my worlds are saved in memory (I'm using ASWM), Huskhomes ends up crashing my server after only a few hours of uptime

This ensures that the player's last world before logging out is always saved in memory

The content shown in the screenshot appears in 20 of the 32 craftplayer instances. The other 12 alive because paper/bukkit things.

[goncalodelima]

https://william278.net/dump/Pv8F5TPeQ1

[goncalodelima]

Opened a fix for this: #1007

Root cause: HomesManager#userHomes was caching Home objects whose owner field held a reference to the live OnlineUser (wrapping the platform Player, e.g. CraftPlayer on Bukkit), because the database getHomes()/getHome() methods reused the passed-in User instance directly instead of a plain data copy. On top of that, removeUserHomes() removed cache entries by UUID string while cacheUserHomes() had cached them by username, so the removal on logout silently never matched and never ran. The result: every player's cached homes - and the live Player object referenced through them - stayed in memory forever after they disconnected, which lines up with the heap dump showing far more CraftPlayer instances than actual online players.