Push textContent also for CDATA_SECTION_NODE nodes (#296)

lppedd · web-flow · commit 075bab4c2a5c · 2025-01-22T19:41:45.000+01:00
* test: assert CDATA sections are included when calling textContent

* fix: push textContent also for CDATA_SECTION_NODE nodes
diff --git a/cjs/interface/element.js b/cjs/interface/element.js
@@ -182,7 +182,8 @@ class Element extends ParentNode {
     const text = [];
     let {[NEXT]: next, [END]: end} = this;
     while (next !== end) {
-      if (next.nodeType === TEXT_NODE)
+      const nodeType = next.nodeType;
+      if (nodeType === TEXT_NODE || nodeType === CDATA_SECTION_NODE)
         text.push(next.textContent);
       next = next[NEXT];
     }
diff --git a/esm/interface/element.js b/esm/interface/element.js
@@ -184,7 +184,8 @@ export class Element extends ParentNode {
     const text = [];
     let {[NEXT]: next, [END]: end} = this;
     while (next !== end) {
-      if (next.nodeType === TEXT_NODE)
+      const nodeType = next.nodeType;
+      if (nodeType === TEXT_NODE || nodeType === CDATA_SECTION_NODE)
         text.push(next.textContent);
       next = next[NEXT];
     }
diff --git a/test/interface/cdata-section.js b/test/interface/cdata-section.js
@@ -8,9 +8,10 @@ let document = (new DOMParser).parseFromString('<html><body><![CDATA[test]]>text
 const [cdata, text] = document.documentElement.lastChild.childNodes;
 
 assert(JSON.stringify(cdata.cloneNode()), '[4,"test"]');
-
 assert(JSON.stringify(text.cloneNode()), '[3,"text"]');
 
+assert(document.documentElement.textContent, 'testtext');
+
 assert(text.data, 'text');
 assert(text.nodeValue, 'text');
 assert(text.textContent, 'text');
@@ -34,4 +35,4 @@ document = (new DOMParser).parseFromString('<?xml version="1.0" encoding="utf-8"
 assert(document.toString(), '<?xml version="1.0" encoding="utf-8"?><html><body><![CDATA[cdata with a <div> tag]]></body></html>');
 
 document = (new DOMParser).parseFromString('<?xml version="1.0" encoding="utf-8"?><html><body><script>/*<![CDATA[*/test/*]]>*/</script></body></html>', 'text/xml');
-assert(document.toString(), '<?xml version="1.0" encoding="utf-8"?><html><body><script>/*<![CDATA[*/test/*]]>*/</script></body></html>');
+assert(document.toString(), '<?xml version="1.0" encoding="utf-8"?><html><body><script>/*<![CDATA[*/test/*]]>*/</script></body></html>');
diff --git a/worker.js b/worker.js
@@ -7764,7 +7764,8 @@ let Element$1 = class Element extends ParentNode {
     const text = [];
     let {[NEXT]: next, [END]: end} = this;
     while (next !== end) {
-      if (next.nodeType === TEXT_NODE)
+      const nodeType = next.nodeType;
+      if (nodeType === TEXT_NODE || nodeType === CDATA_SECTION_NODE)
         text.push(next.textContent);
       next = next[NEXT];
     }
