Skip to content

Commit 957e832

Browse files
committed
Revert CLI arg quoting — spawn args array handles escaping
Node spawn with args array passes values directly to the process without shell interpretation. Adding double quotes caused FireSTARR to receive literal quote characters, breaking argument parsing.
1 parent 5997a96 commit 957e832

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

backend/src/infrastructure/firestarr/FireSTARREngine.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -685,7 +685,7 @@ export class FireSTARREngine implements IFireModelingEngine {
685685
longitude.toString(),
686686
params.startTime,
687687
'--tz', utcOffset.toString(),
688-
'--wx', `"${weatherFile}"`,
688+
'--wx', weatherFile,
689689
'--ffmc', params.previousFFMC.toString(),
690690
'--dmc', params.previousDMC.toString(),
691691
'--dc', params.previousDC.toString(),
@@ -699,17 +699,17 @@ export class FireSTARREngine implements IFireModelingEngine {
699699
if (inputResult.perimeterFile) {
700700
if (isBinaryMode()) {
701701
// Binary mode: use host path directly
702-
args.push('--perim', `"${inputResult.perimeterFile}"`);
702+
args.push('--perim', inputResult.perimeterFile);
703703
} else {
704704
// Docker mode: extract filename and build container path
705705
const perimeterFilename = inputResult.perimeterFile.split('/').pop();
706706
const containerPerimeterFile = `${workingDir}/${perimeterFilename}`;
707-
args.push('--perim', `"${containerPerimeterFile}"`);
707+
args.push('--perim', containerPerimeterFile);
708708
}
709709
}
710710

711711
if (params.outputDateOffsets) {
712-
args.push('--output_date_offsets', `"${JSON.stringify(params.outputDateOffsets)}"`);
712+
args.push('--output_date_offsets', JSON.stringify(params.outputDateOffsets));
713713
}
714714

715715
// Always include simulation area grids for output portability

0 commit comments

Comments
 (0)