Skip to content

Commit 20f3706

Browse files
author
Arpan Chakraborty
committed
fix: move ComponentArrays to weakdeps, add tests, revert Aqua change
1 parent c23056d commit 20f3706

3 files changed

Lines changed: 10 additions & 8 deletions

File tree

Project.toml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,12 @@ BangBang = "198e06fe-97b7-11e9-32a5-e1d131e6ad66"
1111
Bijectors = "76274a88-744f-5084-9051-94815aaf08c4"
1212
Chairmarks = "0ca39b1e-fe0b-4e98-acfc-b1656634c4de"
1313
Compat = "34da2185-b29b-5c13-b0c7-acf172513d20"
14-
ComponentArrays = "b0b7db55-cfe3-40fc-9ded-d10e2dbeff66"
1514
ConstructionBase = "187b0558-2788-49d3-abe0-74a17ed4e7c9"
1615
DifferentiationInterface = "a0c0ee7d-e4b9-4e03-894e-1c5f64a51d63"
1716
Distributions = "31c24e10-a181-5473-b8eb-7969acd0382f"
1817
DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae"
1918
FillArrays = "1a297f60-69ca-5386-bcde-b61e274b549b"
2019
InteractiveUtils = "b77e0a4c-d291-57a0-90e8-8db25a27a240"
21-
JuliaFormatter = "98e50ef6-434e-11e9-1051-2b60c6c9e899"
2220
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
2321
LogDensityProblems = "6fdf6af0-433a-55f7-b3ed-c6c6e0b8df7c"
2422
MacroTools = "1914dd2f-81c6-5fcd-8719-6d5c9610ff09"
@@ -31,6 +29,7 @@ Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
3129
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
3230

3331
[weakdeps]
32+
ComponentArrays = "b0b7db55-cfe3-40fc-9ded-d10e2dbeff66"
3433
EnzymeCore = "f151be2c-9106-41f4-ab19-57ee4f262869"
3534
ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
3635
KernelAbstractions = "63c18a36-062a-441e-b654-da1e3ab1ce7c"
@@ -66,13 +65,12 @@ EnzymeCore = "0.6 - 0.8"
6665
FillArrays = "1.16.0"
6766
ForwardDiff = "0.10.12, 1"
6867
InteractiveUtils = "1"
69-
JuliaFormatter = "2.3.0"
7068
KernelAbstractions = "0.9.33"
7169
LinearAlgebra = "1.6"
7270
LogDensityProblems = "2"
71+
MarginalLogDensities = "0.4.3"
7372
MCMCChains = "6, 7"
7473
MacroTools = "0.5.6"
75-
MarginalLogDensities = "0.4.3"
7674
Mooncake = "0.4.147, 0.5"
7775
OrderedCollections = "1"
7876
PrecompileTools = "1.2.1"
@@ -83,6 +81,3 @@ ReverseDiff = "1"
8381
Statistics = "1"
8482
Test = "1.6"
8583
julia = "1.10.8"
86-
87-
[extras]
88-
ComponentArrays = "b0b7db55-cfe3-40fc-9ded-d10e2dbeff66"

test/Aqua.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ __now__ = now()
77
using Aqua: Aqua
88
using DynamicPPL
99

10-
Aqua.test_all(DynamicPPL; stale_deps=false)
10+
Aqua.test_all(DynamicPPL)
1111

1212
@info "Completed $(@__FILE__) in $(now() - __now__)."
1313

test/varnamedtuple.jl

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ using BangBang: setindex!!, empty!!
2828
using DimensionalData: DimensionalData as DD
2929
using InvertedIndices: InvertedIndices as II
3030
using OffsetArrays: OffsetArrays as OA
31+
using ComponentArrays: ComponentArrays as CA
3132

3233
struct GetSetTestCase
3334
# The VarName being set.
@@ -308,6 +309,12 @@ Base.size(st::SizedThing) = st.size
308309
GetSetTestCase(@varname(oa2[11, -1]), 1.0, oa2, []); skip_setindex=true
309310
)
310311
end
312+
@testset "ComponentArrays" begin
313+
ca = CA.ComponentArray(a=1.0, b=2.0)
314+
test_get_set(GetSetTestCase(@varname(x[1]), 1.0, ca, []))
315+
test_get_set(GetSetTestCase(@varname(x.a), 1.0, ca, []))
316+
test_get_set(GetSetTestCase(@varname(x.b), 2.0, ca, []))
317+
end
311318

312319
@testset "InvertedIndices" begin
313320
# TODO(penelopeysm): Templated setindex fails for II.Not(). I really don't know

0 commit comments

Comments
 (0)