feat: Add issue template validation support.

Author: iphydf

.github/workflows/release.yml .github/workflows/draft.yml.github/workflows/release.yml renamed to .github/workflows/draft.yml

@@ -1,4 +1,4 @@
-name: release
+name: draft
 
 on:
   push:
@@ -7,6 +7,11 @@ on:
     branches: [master]
     types: [opened, reopened, synchronize]
 
+# Cancel old builds when pushing new commits.
+concurrency:
+  group: draft-${{ github.event.pull_request.number || github.ref }}
+  cancel-in-progress: true
+
 jobs:
   release:
     uses: TokTok/ci-tools/.github/workflows/release-drafter.yml@master

.reviewable/completion.js

@@ -0,0 +1,76 @@
+// jshint esversion: 6
+
+// This code will check that the pull request has been approved via GitHub
+// review approval by a minimum number of reviewers and by all assignees, and
+// that no changes were requested by any reviewers.  Only reviewers with write
+// access to the repository are considered.
+//
+// This is very similar to GitHub's built-in branch protection option to require
+// pull request reviews before merging, but allows for much more flexibility and
+// customization.
+
+// dependencies: lodash4
+
+// Helper function to check if a user is a bot.
+function isBotAuthor(author) {
+  return (
+    author.username.endsWith("[bot]") || author.username.startsWith("toktok-")
+  );
+}
+
+function equals(a) {
+  return (b) => a === b;
+}
+
+// The number of approvals required to merge: at least 2 humans must approve the
+// code. If the author is a bot, then 2 approvals are required; otherwise, only
+// 1 approval is required (because 1 human wrote the code, so they approve).
+let numApprovalsRequired = isBotAuthor(review.pullRequest.author) ? 2 : 1;
+
+const approvals = review.pullRequest.approvals;
+
+let numApprovals = _.filter(approvals, equals("approved")).length;
+const numRejections = _.filter(approvals, equals("changes_requested")).length;
+
+const discussionBlockers = _(review.discussions)
+  .filter((x) => !x.resolved)
+  .flatMap("participants")
+  .filter((x) => !x.resolved)
+  .map((user) => _.pick(user, "username"))
+  .value();
+
+let pendingReviewers = _(discussionBlockers)
+  .map((user) => _.pick(user, "username"))
+  .concat(review.pullRequest.requestedReviewers)
+  .value();
+
+const required = _.map(review.pullRequest.assignees, "username");
+_.pull(required, review.pullRequest.author.username);
+if (required.length) {
+  numApprovalsRequired = _.max([required.length, numApprovalsRequired]);
+  numApprovals =
+    _(approvals).pick(required).filter(equals("approved")).size() +
+    _.min([numApprovals, numApprovalsRequired - required.length]);
+  pendingReviewers = _(required)
+    .reject((username) => approvals[username] === "approved")
+    .reject((username) => pendingReviewers.length && approvals[username])
+    .map((username) => ({ username }))
+    .concat(pendingReviewers)
+    .value();
+}
+
+pendingReviewers = _.uniqBy(pendingReviewers, "username");
+
+const description =
+  (numRejections ? `${numRejections} change requests, ` : "") +
+  `${numApprovals} of ${numApprovalsRequired} approvals obtained`;
+const shortDescription =
+  (numRejections ? `${numRejections} ✗, ` : "") +
+  `${numApprovals} of ${numApprovalsRequired} ✓`;
+
+return {
+  completed: numApprovals >= numApprovalsRequired,
+  description,
+  shortDescription,
+  pendingReviewers,
+};

.reviewable/settings.yaml

@@ -0,0 +1,4 @@
+# Reviewable settings file. Read the docs at https://docs.reviewable.io/repositories.html#store-repository-settings-using-the-reviewable-directory
+approval-text: ":lgtm_strong:"
+github-status:
+  updates: always

admin/org.yaml

@@ -67,6 +67,7 @@ teams:
       jin-eld: member
       kitech: member
       Mikhael-Danilov: member
+      nickolay168: member
       nbraud: member
       nurupo: member
       Nyoroon: member
@@ -109,7 +110,6 @@ teams:
     parent: { name: "Contributors" }
     members:
       toktok-releaser: member
-      iphydf: maintainer
 
   "Reviewers":
     <<: *team

admin/repos.yaml

@@ -49,7 +49,8 @@ _common:
       enforcement: "active"
       conditions:
         ref_name:
-          exclude: []
+          exclude:
+            - "refs/heads/release/v*"
           include:
             - "~ALL"
       rules:
@@ -80,6 +81,38 @@ _common:
           bypass_mode: "always"
       current_user_can_bypass: "never"
 
+    "releases":
+      target: "branch"
+      enforcement: "active"
+      conditions:
+        ref_name:
+          exclude: []
+          include:
+            - "refs/heads/release/v*"
+      rules:
+        - type: "deletion"
+        - type: "non_fast_forward"
+        - type: "creation"
+        - type: "required_linear_history"
+        - type: "required_signatures"
+        - type: "pull_request"
+          parameters:
+            required_approving_review_count: 1
+            dismiss_stale_reviews_on_push: false
+            require_code_owner_review: true
+            require_last_push_approval: false
+            required_review_thread_resolution: true
+            automatic_copilot_code_review_enabled: false
+            allowed_merge_methods:
+              - "squash"
+              - "rebase"
+      bypass_actors:
+        # Automation
+        - actor_id: 3772038
+          actor_type: "Team"
+          bypass_mode: "always"
+      current_user_can_bypass: "never"
+
   # GitHub Issue/PR labels.
   labels: &labels
     #############################################################################
@@ -301,7 +334,6 @@ ci-tools:
           - "common / restyled"
           - "release / update_release_draft"
           # Custom
-          - "checks / check-release"
 
 c-toxcore:
   editRepo:
@@ -353,16 +385,30 @@ c-toxcore:
           - "common / restyled"
           - "release / update_release_draft"
           # Custom
+          - "Android (arm64-v8a)"
+          - "Android (armeabi-v7a)"
+          - "Android (x86)"
+          - "Android (x86_64)"
           - "CodeFactor"
+          - "Fuzzing (address)"
+          - "Fuzzing (memory)"
+          - "Fuzzing (undefined)"
+          - "Linux (aarch64)"
+          - "Linux (x86_64)"
+          - "Prepare / Update nightly release tag"
+          - "Prepare / Validate PR"
+          - "Single file / Build"
+          - "Source tarball / Build"
           - "TokTok.c-toxcore"
           - "TokTok.c-toxcore (vcpkg shared)"
           - "TokTok.c-toxcore (vcpkg static)"
+          - "WebAssembly"
+          - "Xcode Framework"
           - "analysis (autotools)"
           - "analysis (clang-tidy)"
           - "analysis (compcert)"
           - "analysis (cppcheck)"
           - "analysis (doxygen)"
-          - "analysis (freebsd)"
           - "analysis (goblint)"
           - "analysis (infer)"
           - "analysis (misra)"
@@ -377,30 +423,35 @@ c-toxcore:
           - "build-netbsd"
           - "build-windows-msvc (2019)"
           - "build-windows-msvc (2022)"
-          - "bazel-dbg"
-          - "bazel-msan"
-          - "bazel-opt"
-          - "build-android"
           - "build-macos"
           - "checks / check-release"
           - "ci/circleci: bazel-asan"
+          - "ci/circleci: bazel-dbg"
+          - "ci/circleci: bazel-msan"
+          - "ci/circleci: bazel-opt"
           - "ci/circleci: cimplefmt"
           - "ci/circleci: clang-analyze"
           - "ci/circleci: cpplint"
           - "ci/circleci: generate-events"
           - "ci/circleci: static-analysis"
-          - "cimple"
+          - "ci/circleci: cimple"
           - "circleci"
           - "coverage-linux"
           - "docker-bootstrap-node"
           - "docker-bootstrap-node-websocket"
           - "docker-clusterfuzz"
           - "docker-esp32"
           - "docker-fuzzer"
-          - "docker-toxcore-js"
           - "docker-windows-mingw (32)"
           - "docker-windows-mingw (64)"
           - "freebsd"
+          - "iOS (ios-arm64)"
+          - "iOS (ios-armv7)"
+          - "iOS (ios-armv7s)"
+          - "iOS (iphonesimulator-arm64)"
+          - "iOS (iphonesimulator-x86_64)"
+          - "macOS (arm64)"
+          - "macOS (x86_64)"
           - "mypy"
           - "sanitizer (asan)"
           - "sanitizer (tsan)"
@@ -608,7 +659,6 @@ hs-cimple:
           - "common / restyled"
           - "release / update_release_draft"
           # Custom
-          - "bazel-opt"
           - "build / stack"
           - "checks / check-release"
 
@@ -880,7 +930,6 @@ hs-tokstyle:
           - "common / restyled"
           - "release / update_release_draft"
           # Custom
-          - "bazel-opt"
           - "build / stack"
           - "checks / check-release"
 
@@ -996,11 +1045,6 @@ js-toxcore-c:
           # Custom
           - "DeepScan"
           - "Hound"
-          - "build (12.x)"
-          - "build (13.x)"
-          - "docker"
-          - "codecov/patch"
-          - "codecov/project"
           - "security/snyk (TokTok)"
 
 jvm-toxcore-c:
@@ -1059,8 +1103,6 @@ py-toxcore-c:
           - "common / restyled"
           - "release / update_release_draft"
           # Custom
-          - "bazel-opt"
-          - "build_linux"
           - "docker"
 
 qTox:
@@ -1088,29 +1130,30 @@ qTox:
           - "common / restyled"
           - "release / update_release_draft"
           # Custom
-          - "bazel-opt"
           - "Alpine (full, Debug)"
           - "Alpine (static) (Release)"
-          - "AppImage on Alpine (full, Release)"
-          - "Android (arm64-v8a, Release, 6.2.4)"
+          - "Android / Build (arm64-v8a, Release, 6.2.4)"
+          - "AppImage / Build on Alpine (x86_64)"
+          - "AppImage / Test on Ubuntu (x86_64)"
+          - "Build RPM package on Fedora"
           - "Check for translatable strings"
           - "Clang-Tidy"
           - "Debian (minimal, Debug)"
           - "Docs"
           - "Fedora with ASAN (full, Debug)"
-          - "Flatpak"
-          - "Test AppImage"
-          - "Test Flatpak"
-          - "Test Windows (x86_64, Release)"
-          - "Test macOS distributable (arm64)"
+          - "Flatpak / Build (x86_64)"
+          - "Flatpak / Test (x86_64)"
+          - "Prepare / Update nightly release tag"
+          - "Prepare / Validate PR"
           - "Ubuntu LTS (full, Release)"
-          - "Update nightly release tag"
-          - "Validate PR"
-          - "Verify release/signatures"
-          - "Windows (x86_64, Release)"
-          - "macOS distributable (arm64)"
+          - "WebAssembly"
+          - "Windows / Build (x86_64, Release)"
+          - "Windows / Test (x86_64, Release)"
+          - "ci/circleci: bazel-opt"
+          - "circleci"
+          - "macOS / Build (arm64, 10.15)"
           - "macOS user (x86_64)"
-          - "release-soon / check"
+          - "netlify / deploy"
 
 spec:
   editRepo:
@@ -1223,7 +1266,6 @@ toxic:
           # Custom
           - "build"
           - "build-static"
-          - "bazel-opt"
           - "infer"
           - "integration-test"
 

github-tools.cabal

@@ -126,6 +126,8 @@ library
     GitHub.Types.Events.WatchEvent
     GitHub.Types.Events.WorkflowJobEvent
     GitHub.Types.Events.WorkflowRunEvent
+    GitHub.Types.IssueTemplate
+    GitHub.Types.Json
     GitHub.Types.PayloadParser
     GitHub.Types.Settings
     GitHub.Types.Workflow