Fix one-on-one calls on Windows on ARM.

Fixes telegramdesktop#30792.

Author: john-preston

Telegram/SourceFiles/calls/calls_video_incoming.cpp

@@ -657,6 +657,33 @@ class Panel::Incoming::RendererRhi final
 #ifndef Q_OS_MAC
 		const auto shadowFs = Ui::Rhi::ShaderFromFile(
 			u":/shaders/argb32.frag.qsb"_q);
+
+		_shadowVertexBuffer = rhi->newBuffer(
+			QRhiBuffer::Dynamic,
+			QRhiBuffer::VertexBuffer,
+			4 * 4 * sizeof(float));
+		_shadowVertexBuffer->create();
+		_shadowUniformBuffer = rhi->newBuffer(
+			QRhiBuffer::Dynamic,
+			QRhiBuffer::UniformBuffer,
+			256);
+		_shadowUniformBuffer->create();
+
+		validateShadowImage();
+
+		_shadowSrb = rhi->newShaderResourceBindings();
+		_shadowSrb->setBindings({
+			QRhiShaderResourceBinding::uniformBuffer(
+				0,
+				QRhiShaderResourceBinding::VertexStage,
+				_shadowUniformBuffer),
+			QRhiShaderResourceBinding::sampledTexture(
+				1,
+				QRhiShaderResourceBinding::FragmentStage,
+				_shadowTexture, _sampler),
+		});
+		_shadowSrb->create();
+
 		QRhiGraphicsPipeline::TargetBlend blend;
 		blend.enable = true;
 		blend.srcColor = QRhiGraphicsPipeline::One;
@@ -672,7 +699,7 @@ class Panel::Incoming::RendererRhi final
 		_shadowBlendPipeline->setTargetBlends({ blend });
 		_shadowBlendPipeline->setTopology(
 			QRhiGraphicsPipeline::TriangleStrip);
-		_shadowBlendPipeline->setShaderResourceBindings(_argb32Srb);
+		_shadowBlendPipeline->setShaderResourceBindings(_shadowSrb);
 		_shadowBlendPipeline->setRenderPassDescriptor(rpDesc);
 		_shadowBlendPipeline->create();
 #endif
@@ -854,6 +881,10 @@ class Panel::Incoming::RendererRhi final
 		rub->updateDynamicBuffer(
 			_vertexBuffer, 0, sizeof(coords), coords);
 
+#ifndef Q_OS_MAC
+		prepareTitleShadow(rub, pw, ph);
+#endif
+
 		cb->beginPass(rt, Qt::black, { 1.0f, 0 }, rub);
 		cb->setGraphicsPipeline(pipeline);
 		cb->setShaderResources(srb);
@@ -863,24 +894,22 @@ class Panel::Incoming::RendererRhi final
 		cb->draw(4);
 
 #ifndef Q_OS_MAC
-		paintTitleShadow(rt, cb, pw, ph);
+		paintTitleShadow(cb, pw, ph);
 #endif
 
 		cb->endPass();
 	}
 
-	void paintTitleShadow(
-			QRhiRenderTarget *rt,
-			QRhiCommandBuffer *cb,
+	// Only records resource updates, must be called outside a render
+	// pass, the batch is then passed to beginPass.
+	void prepareTitleShadow(
+			QRhiResourceUpdateBatch *rub,
 			float pw,
 			float ph) {
 		if (!_shadowBlendPipeline) {
 			return;
 		}
-		validateShadowImage();
-		if (!_shadowTexture) {
-			return;
-		}
+		ensureShadowUploaded(rub);
 		const auto factor = style::DevicePixelRatio();
 		const auto widget = _owner->widget();
 		const auto left = (_owner->_topControlsAlignment
@@ -911,37 +940,27 @@ class Panel::Incoming::RendererRhi final
 		const auto tt = texRect.top() / atlasH;
 		const auto tb = texRect.bottom() / atlasH;
 
-		auto *rub2 = _rhi->nextResourceUpdateBatch();
-		ensureShadowUploaded(rub2);
 		const float shadowCoords[] = {
 			shadowRect.left(), shadowRect.bottom(), tl, tt,
 			shadowRect.right(), shadowRect.bottom(), tr, tt,
 			shadowRect.left(), shadowRect.top(), tl, tb,
 			shadowRect.right(), shadowRect.top(), tr, tb,
 		};
-		rub2->updateDynamicBuffer(
-			_vertexBuffer, 0, sizeof(shadowCoords), shadowCoords);
+		rub->updateDynamicBuffer(
+			_shadowVertexBuffer, 0, sizeof(shadowCoords), shadowCoords);
 		const float viewport2[] = { pw, ph, 0.f, 0.f };
-		rub2->updateDynamicBuffer(
-			_uniformBuffer, 0, sizeof(viewport2), viewport2);
-
-		_argb32Srb->setBindings({
-			QRhiShaderResourceBinding::uniformBuffer(
-				0,
-				QRhiShaderResourceBinding::VertexStage,
-				_uniformBuffer),
-			QRhiShaderResourceBinding::sampledTexture(
-				1,
-				QRhiShaderResourceBinding::FragmentStage,
-				_shadowTexture, _sampler),
-		});
-		_argb32Srb->create();
+		rub->updateDynamicBuffer(
+			_shadowUniformBuffer, 0, sizeof(viewport2), viewport2);
+	}
 
-		cb->resourceUpdate(rub2);
+	void paintTitleShadow(QRhiCommandBuffer *cb, float pw, float ph) {
+		if (!_shadowBlendPipeline) {
+			return;
+		}
 		cb->setGraphicsPipeline(_shadowBlendPipeline);
-		cb->setShaderResources(_argb32Srb);
+		cb->setShaderResources(_shadowSrb);
 		cb->setViewport({ 0, 0, pw, ph });
-		const QRhiCommandBuffer::VertexInput vbuf2(_vertexBuffer, 0);
+		const QRhiCommandBuffer::VertexInput vbuf2(_shadowVertexBuffer, 0);
 		cb->setVertexInput(0, 1, &vbuf2);
 		cb->draw(4);
 	}
@@ -999,7 +1018,10 @@ class Panel::Incoming::RendererRhi final
 		delete _shadowBlendPipeline; _shadowBlendPipeline = nullptr;
 		delete _argb32Srb; _argb32Srb = nullptr;
 		delete _yuv420Srb; _yuv420Srb = nullptr;
+		delete _shadowSrb; _shadowSrb = nullptr;
 		delete _shadowTexture; _shadowTexture = nullptr;
+		delete _shadowVertexBuffer; _shadowVertexBuffer = nullptr;
+		delete _shadowUniformBuffer; _shadowUniformBuffer = nullptr;
 		delete _rgbaTexture; _rgbaTexture = nullptr;
 		delete _yTexture; _yTexture = nullptr;
 		delete _uTexture; _uTexture = nullptr;
@@ -1033,7 +1055,10 @@ class Panel::Incoming::RendererRhi final
 	QRhiGraphicsPipeline *_shadowBlendPipeline = nullptr;
 	QRhiShaderResourceBindings *_argb32Srb = nullptr;
 	QRhiShaderResourceBindings *_yuv420Srb = nullptr;
+	QRhiShaderResourceBindings *_shadowSrb = nullptr;
 	QRhiTexture *_shadowTexture = nullptr;
+	QRhiBuffer *_shadowVertexBuffer = nullptr;
+	QRhiBuffer *_shadowUniformBuffer = nullptr;
 	QSize _shadowSize;
 	QRect _shadowLeftRect;
 	QRect _shadowRightRect;