Skip to content
This repository was archived by the owner on Mar 24, 2026. It is now read-only.

Commit 3d00188

Browse files
authored
Fix SQL capitalization and format in all the Vert.x benchmarks (#10400)
Fix a typo that "world" is misspelled as "word" BTW.
1 parent 5abb655 commit 3d00188

File tree

4 files changed

+18
-18
lines changed
  • frameworks
    • Java
      • vertx-web/src/main/java/io/vertx/benchmark
      • vertx/src/main/java/vertx
    • Kotlin/vertx-web-kotlin-coroutines/src/main/kotlin/io/vertx/benchmark
    • Scala/vertx-web-scala/src/main/scala/vertx

4 files changed

+18
-18
lines changed

frameworks/Java/vertx-web/src/main/java/io/vertx/benchmark/App.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -49,9 +49,9 @@ private void createPgClientBenchmarkAsync(Vertx vertx, JsonObject config, Handle
4949
*/
5050
private final class PgClientBenchmark {
5151

52-
private static final String UPDATE_WORLD = "UPDATE world SET randomnumber=$1 WHERE id=$2";
53-
private static final String SELECT_WORLD = "SELECT id, randomnumber from WORLD where id=$1";
54-
private static final String SELECT_FORTUNE = "SELECT id, message from FORTUNE";
52+
private static final String UPDATE_WORLD = "UPDATE world SET randomnumber = $1 WHERE id = $2";
53+
private static final String SELECT_WORLD = "SELECT id, randomnumber FROM world WHERE id = $1";
54+
private static final String SELECT_FORTUNE = "SELECT id, message FROM fortune";
5555

5656
private final PgConnection client;
5757

frameworks/Java/vertx/src/main/java/vertx/App.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,9 @@ static int getQueries(HttpServerRequest request) {
9090
private static final CharSequence JSON_LENGTH = HttpHeaders.createOptimized("" + new Message("Hello, World!").toJson().length());
9191
private static final CharSequence SERVER = HttpHeaders.createOptimized("vert.x");
9292

93-
private static final String SELECT_WORLD = "SELECT id, randomnumber from WORLD where id=$1";
94-
private static final String SELECT_FORTUNE = "SELECT id, message from FORTUNE";
95-
private static final String SELECT_WORLDS = "SELECT id, randomnumber from WORLD";
93+
private static final String SELECT_WORLD = "SELECT id, randomnumber FROM world WHERE id = $1";
94+
private static final String SELECT_FORTUNE = "SELECT id, message FROM fortune";
95+
private static final String SELECT_WORLDS = "SELECT id, randomnumber FROM world";
9696

9797
public static CharSequence createDateHeader() {
9898
return HttpHeaders.createOptimized(DateTimeFormatter.RFC_1123_DATE_TIME.format(ZonedDateTime.now()));
@@ -213,12 +213,12 @@ private Future<?> initClients(PgConnectOptions options) {
213213

214214
private static String buildAggregatedUpdateQuery(int len) {
215215
StringBuilder sql = new StringBuilder();
216-
sql.append("UPDATE WORLD SET RANDOMNUMBER = CASE ID");
216+
sql.append("UPDATE world SET randomnumber = CASE ID");
217217
for (int i = 0; i < len; i++) {
218218
int offset = (i * 2) + 1;
219219
sql.append(" WHEN $").append(offset).append(" THEN $").append(offset + 1);
220220
}
221-
sql.append(" ELSE RANDOMNUMBER");
221+
sql.append(" ELSE randomnumber");
222222
sql.append(" END WHERE ID IN ($1");
223223
for (int i = 1; i < len; i++) {
224224
int offset = (i * 2) + 1;
@@ -304,12 +304,12 @@ private void handleDb(HttpServerRequest req) {
304304
return;
305305
}
306306
Row row = resultSet.next();
307-
World word = new World(row.getInteger(0), row.getInteger(1));
307+
World world = new World(row.getInteger(0), row.getInteger(1));
308308
MultiMap headers = resp.headers();
309309
headers.add(HttpHeaders.SERVER, SERVER);
310310
headers.add(HttpHeaders.DATE, dateString);
311311
headers.add(HttpHeaders.CONTENT_TYPE, RESPONSE_TYPE_JSON);
312-
resp.end(word.toJson());
312+
resp.end(world.toJson());
313313
} else {
314314
sendError(req, res.cause());
315315
}

frameworks/Kotlin/vertx-web-kotlin-coroutines/src/main/kotlin/io/vertx/benchmark/App.kt

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,9 @@ class App : CoroutineVerticle() {
3636
private const val SERVER = "vertx-web"
3737

3838
// for PgClientBenchmark only
39-
private const val UPDATE_WORLD = "UPDATE world SET randomnumber=$1 WHERE id=$2"
40-
private const val SELECT_WORLD = "SELECT id, randomnumber from WORLD where id=$1"
41-
private const val SELECT_FORTUNE = "SELECT id, message from FORTUNE"
39+
private const val UPDATE_WORLD = "UPDATE world SET randomnumber = $1 WHERE id = $2"
40+
private const val SELECT_WORLD = "SELECT id, randomnumber FROM world WHERE id = $1"
41+
private const val SELECT_FORTUNE = "SELECT id, message FROM fortune"
4242
}
4343

4444
inline fun Route.coroutineHandlerUnconfined(crossinline requestHandler: suspend (RoutingContext) -> Unit): Route =

frameworks/Scala/vertx-web-scala/src/main/scala/vertx/App.scala

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ class App extends ScalaVerticle {
9797

9898
private def handleDb(request: HttpServerRequest): Unit =
9999
client
100-
.preparedQuery("SELECT id, randomnumber from WORLD where id=$1")
100+
.preparedQuery("SELECT id, randomnumber FROM world WHERE id = $1")
101101
.execute(
102102
Tuple.of(App.randomWorld()))
103103
.andThen(
@@ -124,7 +124,7 @@ class App extends ScalaVerticle {
124124
var failed = false
125125
while (i < queries) {
126126
client
127-
.preparedQuery("SELECT id, randomnumber from WORLD where id=$1")
127+
.preparedQuery("SELECT id, randomnumber FROM world WHERE id = $1")
128128
.execute(Tuple.of(App.randomWorld()))
129129
.andThen(
130130
ar => boundary {
@@ -155,7 +155,7 @@ class App extends ScalaVerticle {
155155

156156
val batch = worlds.map(world => Tuple.of(world.randomNumber, world.id)).toList.asJava
157157
conn
158-
.preparedQuery("UPDATE world SET randomnumber=$1 WHERE id=$2")
158+
.preparedQuery("UPDATE world SET randomnumber = $1 WHERE id = $2")
159159
.executeBatch(batch)
160160
.andThen(
161161
ar => boundary {
@@ -180,7 +180,7 @@ class App extends ScalaVerticle {
180180
val id = App.randomWorld()
181181
val index = i
182182
client
183-
.preparedQuery("SELECT id, randomnumber from WORLD where id=$1")
183+
.preparedQuery("SELECT id, randomnumber FROM world WHERE id = $1")
184184
.execute(Tuple.of(id)).andThen(
185185
ar2 => boundary {
186186
if (!failed) {
@@ -201,7 +201,7 @@ class App extends ScalaVerticle {
201201

202202
private def handleFortunes(request: HttpServerRequest): Unit =
203203
client
204-
.preparedQuery("SELECT id, message from FORTUNE")
204+
.preparedQuery("SELECT id, message FROM fortune")
205205
.execute()
206206
.andThen(
207207
ar => boundary {

0 commit comments

Comments
 (0)