Add InvalidSessionAttributeException for better error clarity

Author: TavoNiievez

.jules/palette_dx.md

@@ -0,0 +1,3 @@
+## 2024-05-24 - Custom Exceptions for better clarity
+**Learning:** Generic exceptions like `\InvalidArgumentException` can hide the root cause and make debugging harder.
+**Action:** Prefer creating explicitly named custom domain exceptions (e.g., `InvalidSessionAttributeException` extending `\InvalidArgumentException`) rather than throwing generic exceptions to clearly communicate the failure context and reduce cognitive load for developers.

src/Codeception/Exception/InvalidSessionAttributeException.php

@@ -0,0 +1,9 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Codeception\Exception;
+
+use InvalidArgumentException;
+
+class InvalidSessionAttributeException extends InvalidArgumentException {}

src/Codeception/Module/Symfony/SessionAssertionsTrait.php

@@ -4,7 +4,7 @@
 
 namespace Codeception\Module\Symfony;
 
-use InvalidArgumentException;
+use Codeception\Exception\InvalidSessionAttributeException;
 use Symfony\Component\BrowserKit\Cookie;
 use Symfony\Component\HttpFoundation\Session\SessionFactoryInterface;
 use Symfony\Component\HttpFoundation\Session\SessionInterface;
@@ -174,7 +174,7 @@ public function seeSessionHasValues(array $bindings): void
                 continue;
             }
             if (!is_string($expectedAttr)) {
-                throw new InvalidArgumentException(sprintf('Attribute name must be string, %s given.', get_debug_type($expectedAttr)));
+                throw new InvalidSessionAttributeException(sprintf('Attribute name must be string, %s given.', get_debug_type($expectedAttr)));
             }
             $this->assertTrue($session->has($expectedAttr), "No session attribute with name '{$expectedAttr}'");
         }