Skip to content

Commit 91b3835

Browse files
committed
Ensure vector based isel is used internally
1 parent 3d79018 commit 91b3835

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

mdio/dataset.h

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -632,8 +632,8 @@ class Dataset {
632632
}
633633
std::vector<RangeDescriptor<Index>> firstHalf(slices.begin(), slices.begin() + halfElements);
634634
std::vector<RangeDescriptor<Index>> secondHalf(slices.begin() + halfElements, slices.end());
635-
MDIO_ASSIGN_OR_RETURN(auto ds, isel(firstHalf));
636-
return ds.isel(secondHalf);
635+
MDIO_ASSIGN_OR_RETURN(auto ds, isel(static_cast<const std::vector<RangeDescriptor<Index>>&>(firstHalf)));
636+
return ds.isel(static_cast<const std::vector<RangeDescriptor<Index>>&>(secondHalf));
637637
}
638638

639639
std::vector<RangeDescriptor<Index>> slicesCopy = slices;
@@ -853,7 +853,7 @@ class Dataset {
853853
// The map 'label_to_indices' is now populated with all the relevant
854854
// indices. You can now proceed with further processing based on this map.
855855

856-
return isel(slices);
856+
return isel(static_cast<const std::vector<RangeDescriptor<Index>>&>(slices));
857857
} else if constexpr ((std::is_same_v</*NOLINT: readability/braces*/
858858
Descriptors,
859859
ListDescriptor<
@@ -883,7 +883,7 @@ class Dataset {
883883
// The map 'label_to_indices' is now populated with all the relevant
884884
// indices. You can now proceed with further processing based on this map.
885885

886-
return isel(slices);
886+
return isel(static_cast<const std::vector<RangeDescriptor<Index>>&>(slices));
887887
} else {
888888
std::map<std::string_view, std::pair<Index, Index>>
889889
label_to_range; // pair.first = start, pair.second = stop
@@ -980,7 +980,7 @@ class Dataset {
980980
"No slices could be made from the given descriptors.");
981981
}
982982

983-
return isel(slices);
983+
return isel(static_cast<const std::vector<RangeDescriptor<Index>>&>(slices));
984984
}
985985

986986
return absl::OkStatus();
@@ -1048,7 +1048,7 @@ class Dataset {
10481048

10491049
// TODO(BrianMichell): Coalesce the slices into fewer descriptors.
10501050

1051-
MDIO_ASSIGN_OR_RETURN(auto ds, isel(elementwiseSlices));
1051+
MDIO_ASSIGN_OR_RETURN(auto ds, isel(static_cast<const std::vector<RangeDescriptor<Index>>&>(elementwiseSlices)));
10521052
// TODO(BrianMichell): Make this method more async friendly.
10531053
return tensorstore::ReadyFuture<Dataset>(std::move(ds));
10541054
}

0 commit comments

Comments
 (0)