Skip to content

Commit 66ffc8d

Browse files
committed
Update parameter names in tests from Japanese to English for consistency
1 parent 3a1f657 commit 66ffc8d

File tree

1 file changed

+40
-40
lines changed

1 file changed

+40
-40
lines changed

spec/params_spec.rb

Lines changed: 40 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -73,17 +73,17 @@ def self.name
7373
describe '.new' do
7474
let(:valid_params) do
7575
{
76-
name: '田中太郎',
76+
name: 'Tanaka Taro',
7777
7878
age: 30,
7979
address: {
8080
postal_code: '123-4567',
81-
prefecture: '東京都',
82-
city: '渋谷区',
83-
street: '道玄坂1-2-3'
81+
prefecture: 'Tokyo',
82+
city: 'Shibuya-ku',
83+
street: 'Saka 1-2-3'
8484
},
8585
hobbies: [
86-
{ name: 'プログラミング', level: 3, years_experience: 10 },
86+
{ name: 'programming', level: 3, years_experience: 10 },
8787
{ name: '読書', level: 2, years_experience: 5 }
8888
],
8989
tags: %w[Ruby Rails 技術書]
@@ -95,7 +95,7 @@ def self.name
9595

9696
it {
9797
expect(user_param).to have_attributes(
98-
name: '田中太郎',
98+
name: 'Tanaka Taro',
9999
100100
age: 30
101101
)
@@ -109,9 +109,9 @@ def self.name
109109
it {
110110
expect(address).to have_attributes(
111111
postal_code: '123-4567',
112-
prefecture: '東京都',
113-
city: '渋谷区',
114-
street: '道玄坂1-2-3'
112+
prefecture: 'Tokyo',
113+
city: 'Shibuya-ku',
114+
street: 'Saka 1-2-3'
115115
)
116116
}
117117
end
@@ -121,7 +121,7 @@ def self.name
121121

122122
it { is_expected.to be_an(Array) }
123123
it { is_expected.to contain_exactly(hobby_parameter_class, hobby_parameter_class) }
124-
it { expect(hobbies[0]).to have_attributes(name: 'プログラミング', level: 3, years_experience: 10) }
124+
it { expect(hobbies[0]).to have_attributes(name: 'programming', level: 3, years_experience: 10) }
125125
it { expect(hobbies[1]).to have_attributes(name: '読書', level: 2, years_experience: 5) }
126126
end
127127

@@ -140,7 +140,7 @@ def self.name
140140
end
141141

142142
it 'filters unpermitted parameters' do
143-
expect(user_param.name).to eq('田中太郎')
143+
expect(user_param.name).to eq('Tanaka Taro')
144144
expect { user_param.unpermitted }.to raise_error(NoMethodError)
145145
end
146146
end
@@ -158,17 +158,17 @@ def self.name
158158

159159
let(:valid_params) do
160160
{
161-
name: '田中太郎',
161+
name: 'Tanaka Taro',
162162
163163
age: 30,
164164
address: {
165165
postal_code: '123-4567',
166-
prefecture: '東京都',
167-
city: '渋谷区',
168-
street: '道玄坂1-2-3'
166+
prefecture: 'Tokyo',
167+
city: 'Shibuya-ku',
168+
street: 'Saka 1-2-3'
169169
},
170170
hobbies: [
171-
{ name: 'プログラミング', level: 3, years_experience: 10 }
171+
{ name: 'programming', level: 3, years_experience: 10 }
172172
]
173173
}
174174
end
@@ -186,9 +186,9 @@ def self.name
186186
age: -1, # invalid
187187
address: {
188188
postal_code: '123-4567',
189-
prefecture: '東京都',
190-
city: '渋谷区',
191-
street: '道玄坂1-2-3'
189+
prefecture: 'Tokyo',
190+
city: 'Shibuya-ku',
191+
street: 'Saka 1-2-3'
192192
}
193193
}
194194
end
@@ -206,14 +206,14 @@ def self.name
206206

207207
let(:invalid_address_params) do
208208
{
209-
name: '田中太郎',
209+
name: 'Tanaka Taro',
210210
211211
age: 30,
212212
address: {
213213
postal_code: 'invalid', # invalid format
214214
prefecture: '', # blank
215-
city: '渋谷区',
216-
street: '道玄坂1-2-3'
215+
city: 'Shibuya-ku',
216+
street: 'Saka 1-2-3'
217217
}
218218
}
219219
end
@@ -230,7 +230,7 @@ def self.name
230230

231231
let(:invalid_hobbies_params) do
232232
{
233-
name: '田中太郎',
233+
name: 'Tanaka Taro',
234234
235235
age: 30,
236236
hobbies: [
@@ -256,33 +256,33 @@ def self.name
256256

257257
let(:params) do
258258
{
259-
name: '田中太郎',
259+
name: 'Tanaka Taro',
260260
261261
age: 30,
262262
address: {
263263
postal_code: '123-4567',
264-
prefecture: '東京都',
265-
city: '渋谷区',
266-
street: '道玄坂1-2-3'
264+
prefecture: 'Tokyo',
265+
city: 'Shibuya-ku',
266+
street: 'Saka 1-2-3'
267267
},
268268
hobbies: [
269-
{ name: 'プログラミング', level: 3, years_experience: 10 }
269+
{ name: 'programming', level: 3, years_experience: 10 }
270270
],
271271
tags: %w[Ruby Rails]
272272
}
273273
end
274274

275275
it 'returns attributes with objects converted to hashes' do
276276
expect(attributes).to include(
277-
'name' => '田中太郎',
277+
'name' => 'Tanaka Taro',
278278
'address' => hash_including(
279279
'postal_code' => '123-4567',
280-
'prefecture' => '東京都',
281-
'city' => '渋谷区',
282-
'street' => '道玄坂1-2-3'
280+
'prefecture' => 'Tokyo',
281+
'city' => 'Shibuya-ku',
282+
'street' => 'Saka 1-2-3'
283283
),
284284
'hobbies' => array_including(
285-
hash_including('name' => 'プログラミング', 'level' => 3, 'years_experience' => 10)
285+
hash_including('name' => 'programming', 'level' => 3, 'years_experience' => 10)
286286
),
287287
'tags' => %w[Ruby Rails]
288288
)
@@ -293,15 +293,15 @@ def self.name
293293

294294
it 'returns symbolized attributes' do
295295
expect(attributes).to include(
296-
name: '田中太郎',
296+
name: 'Tanaka Taro',
297297
address: hash_including(
298298
postal_code: '123-4567',
299-
prefecture: '東京都',
300-
city: '渋谷区',
301-
street: '道玄坂1-2-3'
299+
prefecture: 'Tokyo',
300+
city: 'Shibuya-ku',
301+
street: 'Saka 1-2-3'
302302
),
303303
hobbies: array_including(
304-
hash_including(name: 'プログラミング', level: 3, years_experience: 10)
304+
hash_including(name: 'programming', level: 3, years_experience: 10)
305305
),
306306
tags: %w[Ruby Rails]
307307
)
@@ -315,7 +315,7 @@ def self.name
315315

316316
let(:params_with_nil) do
317317
{
318-
name: '田中太郎',
318+
name: 'Tanaka Taro',
319319
320320
age: 30,
321321
address: nil,
@@ -338,7 +338,7 @@ def self.name
338338

339339
let(:params_with_empty_arrays) do
340340
{
341-
name: '田中太郎',
341+
name: 'Tanaka Taro',
342342
343343
age: 30,
344344
hobbies: [],

0 commit comments

Comments
 (0)