fix: move validation errors check outside try catch block

Author: Ivan Maretić

packages/job-worker/src/playout/adlibAction.ts

@@ -240,10 +240,12 @@ export async function executeActionInner(
 		)} (${actionParameters.triggerMode})`
 	)
 
+	let result: ExecuteActionResult | void
+
 	try {
 		const blueprintPersistentState = new PersistentPlayoutStateStore(playoutModel.playlist.previousPersistentState)
 
-		const result = await blueprint.blueprint.executeAction(
+		result = await blueprint.blueprint.executeAction(
 			actionContext,
 			blueprintPersistentState,
 			actionParameters.actionId,
@@ -253,16 +255,6 @@ export async function executeActionInner(
 			actionParameters.publicData,
 			actionParameters.actionOptions ?? {}
 		)
-		if (result && result.validationErrors) {
-			throw UserError.from(
-				new Error(
-					`AdLib Action "${actionParameters.actionId}" validation failed: ${JSON.stringify(result.validationErrors)}`
-				),
-				UserErrorMessage.ValidationFailed,
-				undefined,
-				409
-			)
-		}
 
 		if (blueprintPersistentState.hasChanges) {
 			playoutModel.setBlueprintPersistentState(blueprintPersistentState.getAll())
@@ -272,6 +264,17 @@ export async function executeActionInner(
 		throw UserError.fromUnknown(err)
 	}
 
+	if (result && result.validationErrors) {
+		throw UserError.from(
+			new Error(
+				`AdLib Action "${actionParameters.actionId}" validation failed: ${JSON.stringify(result.validationErrors)}`
+			),
+			UserErrorMessage.ValidationFailed,
+			undefined,
+			409
+		)
+	}
+
 	// Store any notes generated by the action
 	storeNotificationsForCategory(
 		playoutModel,