Naming conflict with cr_realloc

[yayuwang0624]

I encountered a naming conflict when testing QuickJS as a dynamic library with Criterion.

Criterion side

Criterion/include/criterion/alloc.h

Line 86 in f6d40d5

CR_API void *cr_realloc(void *ptr, size_t size);

QuickJS side https://github.com/bellard/quickjs/blob/c73a435f365e5250dd529cde00675528d7609edf/libunicode.h#L53

int cr_realloc(CharRange *cr, int size);

Somehow, the quickjs internal invokes the Criterion cr_realloc function instead of its own one, and causes allocation failure.

I wonder if there is a recommended way to avoid this conflict when using Criterion with libraries that have functions named cr_*?

[MrAnno]

Hi,

Unfortunately, that's a symbol conflict, which is not easy to resolve in a general and portable way.

$ nm -gD /usr/lib/libcriterion.so | grep cr_realloc
0000000000004ce0 T cr_realloc

A few tips that are not too elegant and unportable:

• you can change the visibility of the cr_realloc() function and recompile Criterion, if you don't want to use that function directly.
• you can try playing with dlopen()'s RTLD_LOCAL and RTLD_LAZY flags to isolate those symbols in those two libraries
• switching the load order of these libraries may solve your issue in this specific case