Fix deployment connection signal sent before updating status

Author: Su5eD

src/service/storage/deployment.cc

@@ -308,8 +308,6 @@ namespace service {
             deployLog->info("==   Project deployment complete  ==");
             deployLog->info("====================================");
 
-            global::connections->complete(projectId, true);
-
             deployment.setStatus(enumToStr(DeploymentStatus::SUCCESS));
 
             // Cleanup previous data
@@ -328,8 +326,6 @@ namespace service {
             deployLog->error("!!   Project deployment failed    !!");
             deployLog->error("!!================================!!");
 
-            global::connections->complete(projectId, false);
-
             deployment.setStatus(enumToStr(DeploymentStatus::ERROR));
 
             remove_all(deploymentDir);
@@ -338,6 +334,8 @@ namespace service {
         remove_all(clonePath);
         co_await global::database->updateModel(deployment);
 
+        global::connections->complete(projectId, result == ProjectError::OK);
+
         co_return co_await completeTask<std::tuple<std::optional<Deployment>, ProjectError>>(taskKey, {deployment, result});
     }
 

src/service/storage/storage.cc

@@ -169,9 +169,6 @@ namespace service {
                 vProject->setDefaultVersion(*defaultProject);
                 co_return TaskResult<ProjectBasePtr>{std::make_shared<ResolvedProject>(*vProject)};
             }
-            if (!co_await defaultProject->hasVersion(*version)) {
-                logger.error("Failed to find existing version '{}' for '{}'", *version, project.getValueOfId());
-            }
         }
 
         if (!defaultProject) {