chore: update dependencies, fix linting errors

double-beep · web-flow · commit 094fb9649c21 · 2025-12-22T14:16:02.000Z
diff --git a/dist/AdvancedFlagging.user.js b/dist/AdvancedFlagging.user.js
@@ -3496,7 +3496,7 @@
       const tooltipFlagText = this.post.deleted ? "" : flagText;
       const commentText = this.getCommentText(flagType);
       const tooltipCommentText = (this.post.deleted ? "" : commentText) || "";
-      const reportTypeHuman = reportType === "NoFlag" || !this.post.deleted ? getHumanFromDisplayName(reportType) : "";
+      const reportTypeHuman = reportType === "NoFlag" /* NoFlag */ || !this.post.deleted ? getHumanFromDisplayName(reportType) : "";
       const popoverParent = document.createElement("div");
       Object.entries({
         Flag: reportTypeHuman,
@@ -3638,7 +3638,7 @@
       flex.remove();
       this.post.progress.delete();
       StackExchange.helpers.removeSpinner = old;
-      if (reportType !== "NoFlag") return;
+      if (reportType !== "NoFlag" /* NoFlag */) return;
       if (success) {
         attachPopover(this.post.done, `Performed action ${displayName}`);
         $(this.post.done).fadeIn();
diff --git a/eslint.config.js b/eslint.config.js
@@ -57,7 +57,6 @@ export default tseslint.config({
         '@stylistic/brace-style': ['error', '1tbs'],
         '@stylistic/comma-dangle': 'off',
         '@stylistic/indent-binary-ops': 'off',
-        '@stylistic/space-before-function-paren': 'off',
         '@stylistic/type-annotation-spacing': [
             'warn',
             {
diff --git a/npm-shrinkwrap.json b/npm-shrinkwrap.json
diff --git a/package.json b/package.json
@@ -10,18 +10,18 @@
   "author": "Robert Rudman <rjrudman@gmail.com> (https://github.com/rjrudman)",
   "license": "ISC",
   "devDependencies": {
-    "@eslint/js": "^9.34.0",
-    "@stylistic/eslint-plugin": "^5.3.1",
+    "@eslint/js": "^9.39.2",
+    "@stylistic/eslint-plugin": "^5.6.1",
     "@types/jquery": "3.5.33",
-    "@types/node": "^24.3.0",
-    "@types/tampermonkey": "5.0.4",
+    "@types/node": "^25.0.3",
+    "@types/tampermonkey": "5.0.5",
     "@userscripters/stackexchange-global-types": "^2.8.2",
-    "esbuild": "^0.25.9",
-    "typescript": "5.9.2",
-    "typescript-eslint": "^8.41.0"
+    "esbuild": "^0.27.2",
+    "typescript": "5.9.3",
+    "typescript-eslint": "^8.50.0"
   },
   "dependencies": {
-    "@stackoverflow/stacks-icons": "^6.6.1",
+    "@stackoverflow/stacks-icons": "^6.8.0",
     "@userscripters/stacks-helpers": "1.1.3"
   },
   "repository": {
diff --git a/src/Configuration.ts b/src/Configuration.ts
@@ -4,21 +4,21 @@ import {
     CachedCategory,
     CachedFlag
 } from './UserscriptTools/Store';
-import { Flags, flagCategories } from './FlagTypes';
+import { flagCategories } from './FlagTypes';
 
-import { FlagNames, displayStacksToast, getFlagTypeFromFlagId } from './shared';
+import { Flags, displayStacksToast, getFlagTypeFromFlagId } from './shared';
 
 import { buildConfigurationOverlay } from './modals/config';
 import { setupCommentsAndFlagsModal } from './modals/comments/main';
 
 export function isSpecialFlag(flagName: Flags, checkNoFlag = true): boolean {
     const arrayOfFlags: Flags[] = [
-        FlagNames.ModFlag,
-        FlagNames.Plagiarism
+        Flags.ModFlag,
+        Flags.Plagiarism
     ];
 
     if (checkNoFlag) {
-        arrayOfFlags.push(FlagNames.NoFlag);
+        arrayOfFlags.push(Flags.NoFlag);
     }
 
     return arrayOfFlags.includes(flagName);
@@ -97,7 +97,7 @@ function setupDefaults(): void {
         // filter by id because names can be edited by the user
         if (cachedFlag.id !== 3 && cachedFlag.id !== 5) return;
 
-        cachedFlag.reportType = FlagNames.Plagiarism;
+        cachedFlag.reportType = Flags.Plagiarism;
     });
     Store.updateFlagTypes();
 
@@ -136,9 +136,10 @@ function setupDefaults(): void {
     // https://meta.stackoverflow.com/a/434697
     Store.flagTypes
         // @ts-expect-error VLQ flag is removed, see the link above
+        // eslint-disable-next-line @typescript-eslint/no-unsafe-enum-comparison
         .filter(({ reportType }) => reportType === 'PostLowQuality')
         .forEach(flagType => {
-            flagType.reportType = FlagNames.NAA;
+            flagType.reportType = Flags.NAA;
         });
 
     Store.updateFlagTypes();
diff --git a/src/FlagTypes.ts b/src/FlagTypes.ts
@@ -1,13 +1,6 @@
-import { FlagTypeFeedbacks, PostType, FlagNames } from './shared';
+import { FlagTypeFeedbacks, PostType, Flags } from './shared';
 import { CachedFlag } from './UserscriptTools/Store';
 
-export type Flags = 'AnswerNotAnAnswer'
-    | 'PostOffensive'
-    | 'PostSpam'
-    | 'NoFlag'
-    | 'PostOther'
-    | 'PlagiarizedContent';
-
 const deletedAnswers = '/help/deleted-answers';
 const commentHelp = '/help/privileges/comment';
 const reputationHelp = '/help/whats-reputation';
@@ -47,14 +40,14 @@ export const flagCategories: FlagCategory[] = [
             {
                 id: 1,
                 displayName: 'Spam',
-                reportType: FlagNames.Spam,
+                reportType: Flags.Spam,
                 feedbacks: { Smokey: 'tpu-', Natty: 'tp', Guttenberg: '', 'Generic Bot': 'track' },
                 sendWhenFlagRaised: true
             },
             {
                 id: 2,
                 displayName: 'Rude or Abusive',
-                reportType: FlagNames.Rude,
+                reportType: Flags.Rude,
                 feedbacks: { Smokey: 'tpu-', Natty: 'tp', Guttenberg: '', 'Generic Bot': 'track' },
                 sendWhenFlagRaised: true
             }
@@ -69,7 +62,7 @@ export const flagCategories: FlagCategory[] = [
             {
                 id: 3,
                 displayName: 'Plagiarism',
-                reportType: FlagNames.Plagiarism,
+                reportType: Flags.Plagiarism,
                 flagText: 'Possible plagiarism of the linked answer, as can be seen here $COPYPASTOR$',
                 // don't send feedback to Smokey despite https://charcoal-se.org/smokey/Feedback-Guidance.html#plagiarism
                 feedbacks: { Smokey: '', Natty: '', Guttenberg: 'tp', 'Generic Bot': '' },
@@ -78,7 +71,7 @@ export const flagCategories: FlagCategory[] = [
             {
                 id: 4,
                 displayName: 'Duplicate answer',
-                reportType: FlagNames.ModFlag,
+                reportType: Flags.ModFlag,
                 flagText: 'The post is a repost of their other answer: $TARGET$, but as there are slight differences '
                         + '(see $COPYPASTOR$), an auto flag would not be raised.',
                 comments: {
@@ -92,7 +85,7 @@ export const flagCategories: FlagCategory[] = [
             {
                 id: 5,
                 displayName: 'Bad attribution',
-                reportType: FlagNames.Plagiarism,
+                reportType: Flags.Plagiarism,
                 flagText: 'This post is copied from $TARGET$, as can be seen here $COPYPASTOR$. The author '
                                + 'only added a link to the other answer, which is [not the proper way of attribution]'
                                + '(//stackoverflow.blog/2009/06/25/attribution-required).',
@@ -110,7 +103,7 @@ export const flagCategories: FlagCategory[] = [
             {
                 id: 6,
                 displayName: 'Link Only',
-                reportType: FlagNames.NAA,
+                reportType: Flags.NAA,
                 comments: {
                     // comment by Yunnosch: https://chat.stackoverflow.com/transcript/message/57442309
                     low: 'A link to a solution is welcome, but please ensure your answer is useful without it: '
@@ -126,7 +119,7 @@ export const flagCategories: FlagCategory[] = [
             {
                 id: 7,
                 displayName: 'Not an answer',
-                reportType: FlagNames.NAA,
+                reportType: Flags.NAA,
                 comments: {
                     low: 'This does not provide an answer to the question. You can [search for similar questions](/search), '
                        + 'or refer to the related and linked questions on the right-hand side of the page to find an answer. '
@@ -144,7 +137,7 @@ export const flagCategories: FlagCategory[] = [
             {
                 id: 8,
                 displayName: 'Thanks',
-                reportType: FlagNames.NAA,
+                reportType: Flags.NAA,
                 comments: {
                     low: 'Please don\'t add _thanks_ as answers. They don\'t actually provide an answer to the question, and '
                        + 'can be perceived as noise by its future visitors. Once you [earn](//meta.stackoverflow.com/q/146472) '
@@ -164,7 +157,7 @@ export const flagCategories: FlagCategory[] = [
             {
                 id: 9,
                 displayName: 'Me too',
-                reportType: FlagNames.NAA,
+                reportType: Flags.NAA,
                 comments: {
                     low: 'Please don\'t add *Me too* as answers. It doesn\'t actually provide an answer to the question. '
                        + 'If you have a different but related question, then [ask](/questions/ask) it (reference this one '
@@ -178,7 +171,7 @@ export const flagCategories: FlagCategory[] = [
             {
                 id: 10,
                 displayName: 'Library',
-                reportType: FlagNames.NAA,
+                reportType: Flags.NAA,
                 comments: {
                     low: 'Please don\'t just post some tool or library as an answer. At least demonstrate '
                        + '[how it solves the problem](//meta.stackoverflow.com/a/251605) in the answer itself.',
@@ -189,7 +182,7 @@ export const flagCategories: FlagCategory[] = [
             {
                 id: 11,
                 displayName: 'Comment',
-                reportType: FlagNames.NAA,
+                reportType: Flags.NAA,
                 comments: {
                     low: 'This does not provide an answer to the question. Once you have sufficient '
                        + `[reputation](${reputationHelp}) you will be able to [comment on any post](${commentHelp}); instead, `
@@ -202,7 +195,7 @@ export const flagCategories: FlagCategory[] = [
             {
                 id: 12,
                 displayName: 'Duplicate',
-                reportType: FlagNames.NAA,
+                reportType: Flags.NAA,
                 comments: {
                     low: 'Instead of posting an answer which merely links to another answer, please instead '
                        + `[flag the question](${flagPosts}) as a duplicate.`,
@@ -213,7 +206,7 @@ export const flagCategories: FlagCategory[] = [
             {
                 id: 13,
                 displayName: 'Non English',
-                reportType: FlagNames.NAA,
+                reportType: Flags.NAA,
                 comments: {
                     low: 'Please write your answer in English, as Stack Overflow is an '
                        + '[English-only site](//meta.stackoverflow.com/a/297680).',
@@ -224,7 +217,7 @@ export const flagCategories: FlagCategory[] = [
             {
                 id: 14,
                 displayName: 'Should be an edit',
-                reportType: FlagNames.NAA,
+                reportType: Flags.NAA,
                 comments: {
                     low: 'Please use the edit link on your question to add additional information. '
                        + 'The "Post Answer" button should be used only for complete answers to the question.',
@@ -243,21 +236,21 @@ export const flagCategories: FlagCategory[] = [
             {
                 id: 15,
                 displayName: 'Looks Fine',
-                reportType: FlagNames.NoFlag,
+                reportType: Flags.NoFlag,
                 feedbacks: { Smokey: 'fp-', Natty: 'fp', Guttenberg: 'fp', 'Generic Bot': '' },
                 sendWhenFlagRaised: false
             },
             {
                 id: 16,
                 displayName: 'Needs Editing',
-                reportType: FlagNames.NoFlag,
+                reportType: Flags.NoFlag,
                 feedbacks: { Smokey: 'fp-', Natty: 'ne', Guttenberg: 'fp', 'Generic Bot': '' },
                 sendWhenFlagRaised: false
             },
             {
                 id: 17,
                 displayName: 'Vandalism',
-                reportType: FlagNames.NoFlag,
+                reportType: Flags.NoFlag,
                 feedbacks: { Smokey: 'tp-', Natty: '', Guttenberg: 'fp', 'Generic Bot': '' },
                 sendWhenFlagRaised: false
             }
@@ -269,7 +262,7 @@ export function getEmptyFlagType(id: number, belongsTo: string): CachedFlag {
     return {
         id,
         displayName: 'Name',
-        reportType: FlagNames.NoFlag,
+        reportType: Flags.NoFlag,
         feedbacks: { Smokey: '', Natty: '', Guttenberg: '', 'Generic Bot': '' },
         sendWhenFlagRaised: false,
         downvote: false,
diff --git a/src/UserscriptTools/Post.ts b/src/UserscriptTools/Post.ts
@@ -1,8 +1,7 @@
 import { page } from '../AdvancedFlagging';
-import { Flags } from '../FlagTypes';
 import {
     PostType,
-    FlagNames,
+    Flags,
     getFormDataFromObject,
     addXHRListener,
     addProgress,
@@ -122,7 +121,7 @@ export default class Post {
             // plagiarism flag: fill "Link(s) to original content"
             // note wrt link: site will always be Stack Overflow,
             //                post will always be an answer.
-            customData: flagName === FlagNames.Plagiarism
+            customData: flagName === Flags.Plagiarism
                 ? JSON.stringify({ plagiarizedSource: `https:${targetUrl}` })
                 : ''
         };
diff --git a/src/modals/comments/rows.ts b/src/modals/comments/rows.ts
@@ -218,7 +218,7 @@ export function getTextareas({
         textarea.insertAdjacentElement('afterend', charsLeft);
 
         // change the string on keyup
-        textarea.addEventListener('keyup', function() {
+        textarea.addEventListener('keyup', function () {
             const newCharsLeft = getCharSpan(this, contentType);
 
             this.nextElementSibling?.replaceWith(newCharsLeft);
diff --git a/src/modals/comments/submit.ts b/src/modals/comments/submit.ts
@@ -2,8 +2,8 @@ import {
     displayStacksToast,
     FlagTypeFeedbacks,
     getFlagTypeFromFlagId,
+    Flags
 } from '../../shared';
-import { Flags } from '../../FlagTypes';
 import { isSpecialFlag } from '../../Configuration';
 import { CachedFlag, Store } from '../../UserscriptTools/Store';
 
diff --git a/src/popover.ts b/src/popover.ts
@@ -5,8 +5,8 @@ import {
     attachPopover,
     getHumanFromDisplayName,
 
+    Flags,
     getFullFlag,
-    FlagNames,
     delay,
     configBoxes
 } from './shared';
@@ -18,7 +18,6 @@ import { Store, CachedFlag } from './UserscriptTools/Store';
 import Reporter from './UserscriptTools/Reporter';
 import Page from './UserscriptTools/Page';
 import { Progress } from './UserscriptTools/Progress';
-import { Flags } from './FlagTypes';
 
 const noneSpan = document.createElement('span');
 noneSpan.classList.add('o50');
@@ -33,11 +32,11 @@ export class Popover {
 
     // do not vote to delete if reportType is one of these:
     private readonly excludedTypes: Flags[] = [
-        FlagNames.Plagiarism,
-        FlagNames.ModFlag,
-        FlagNames.NoFlag,
-        FlagNames.Spam,
-        FlagNames.Rude
+        Flags.Plagiarism,
+        Flags.ModFlag,
+        Flags.NoFlag,
+        Flags.Spam,
+        Flags.Rude
     ];
 
     private makeMenu(): HTMLUListElement {
@@ -234,7 +233,7 @@ export class Popover {
         const commentText = this.getCommentText(flagType);
         const tooltipCommentText = (this.post.deleted ? '' : commentText) || '';
 
-        const reportTypeHuman = reportType === 'NoFlag' || !this.post.deleted
+        const reportTypeHuman = reportType === Flags.NoFlag || !this.post.deleted
             ? getHumanFromDisplayName(reportType)
             : '';
 
@@ -386,7 +385,7 @@ export class Popover {
 
         const natty = this.post.reporters.Natty;
         if (natty) {
-            natty.raisedRedFlag = reportType === FlagNames.Spam || reportType === FlagNames.Rude;
+            natty.raisedRedFlag = reportType === Flags.Spam || reportType === Flags.Rude;
         }
 
         // if feedback is sent successfully, the success variable is true, otherwise false
@@ -438,11 +437,11 @@ export class Popover {
             }
 
             // flag & delete
-            if (flag && reportType !== FlagNames.NoFlag
+            if (flag && reportType !== Flags.NoFlag
                 // as requested by Zoe: https://chat.stackoverflow.com/transcript/message/57483258
                 && (!StackExchange.options.user.isModerator
-                    || reportType === FlagNames.Spam
-                    || reportType === FlagNames.Rude
+                    || reportType === Flags.Spam
+                    || reportType === Flags.Rude
                 )
             ) {
                 const humanFlag = getHumanFromDisplayName(reportType);
@@ -497,7 +496,7 @@ export class Popover {
         StackExchange.helpers.removeSpinner = old;
 
         // don't show performed/failed action icons if post has been flagged
-        if (reportType !== 'NoFlag') return;
+        if (reportType !== Flags.NoFlag) return;
 
         if (success) {
             attachPopover(this.post.done, `Performed action ${displayName}`);
diff --git a/src/shared.ts b/src/shared.ts

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,6 @@ export default tseslint.config({`
`57`	`57`	`'@stylistic/brace-style': ['error', '1tbs'],`
`58`	`58`	`'@stylistic/comma-dangle': 'off',`
`59`	`59`	`'@stylistic/indent-binary-ops': 'off',`
`60`		`- '@stylistic/space-before-function-paren': 'off',`
`61`	`60`	`'@stylistic/type-annotation-spacing': [`
`62`	`61`	`'warn',`
`63`	`62`	`{`