fix: PR corrections round 3

Refs: #121.

Author: ahmadbky

.github/workflows/ci.yml

@@ -62,7 +62,7 @@ jobs:
         uses: actions/checkout@v4
 
       - name: Setup Rust
-        uses: dtolnay/rust-toolchain@1.92.0
+        uses: dtolnay/rust-toolchain@1.94.0
 
       - name: Setup Clippy
         run: rustup component add clippy

Cargo.toml

@@ -43,7 +43,7 @@ once_cell = "1.21.3"
 csv = "1.4.0"
 mkenv = "1.0.2"
 nom = "8.0.0"
-pin-project-lite = "0.2.16"
+pin-project-lite = "0.2.17"
 sea-orm = { version = "1.1.19", features = [
   "runtime-tokio",
   "macros",

crates/game_api/Cargo.toml

@@ -34,7 +34,7 @@ once_cell = { workspace = true }
 records-lib = { path = "../records_lib", features = ["tracing"] }
 mkenv = { workspace = true }
 nom = { workspace = true }
-pin-project-lite = { version = "0.2.17" }
+pin-project-lite = { workspace = true }
 request_filter = { path = "../request_filter", optional = true }
 dsc_webhook = { path = "../dsc_webhook", features = ["actix-web"] }
 sea-orm = { workspace = true }

crates/game_api/src/configure/slow_req_mw.rs

@@ -54,7 +54,13 @@ impl TimeoutHandler for WebhookTimeoutHandler {
         let client = self.0.clone();
 
         tokio::task::spawn(async move {
-            if let Err(e) = client.post(wh_url).json(&wh_msg).send().await {
+            if let Err(e) = client
+                .post(wh_url)
+                .json(&wh_msg)
+                .send()
+                .await
+                .and_then(|e| e.error_for_status())
+            {
                 tracing::error!("couldn't send timeout error to webhook: {e}. body:\n{wh_msg:#?}");
             }
         });
@@ -216,17 +222,19 @@ where
     fn poll(self: Pin<&mut Self>, cx: &mut Context<'_>) -> Poll<Self::Output> {
         let this = self.project();
 
-        if let Poll::Ready(res) = this.inner_fut.poll(cx) {
-            return Poll::Ready(res);
-        }
-
+        // To ensure catching the timeout (in case the async runtime is laggy),
+        // we poll the timer first.
         if !*this.is_handled
             && let Poll::Ready(_) = this.sleep_fut.poll(cx)
         {
             this.handler.on_timeout(this.info);
             *this.is_handled = true;
         }
 
+        if let Poll::Ready(res) = this.inner_fut.poll(cx) {
+            return Poll::Ready(res);
+        }
+
         Poll::Pending
     }
 }