Replace All Otp Emails with Null (#5209)

Replace all otp emails with NULL so that they use the current email (rather than a potentially stale one) instead

Author: axelstudios

seed/migrations/0251_null_emaildevice_email.py

@@ -0,0 +1,17 @@
+from django.db import migrations
+
+
+def null_otp_email(apps, schema_editor):
+    EmailDevice = apps.get_model("otp_email", "EmailDevice")
+    EmailDevice.objects.exclude(email__isnull=True).update(email=None)
+
+
+class Migration(migrations.Migration):
+    dependencies = [
+        ("otp_email", "0006_add_timestamps"),
+        ("seed", "0250_remove_goal_current_cycle_goal_partner_note_and_more"),
+    ]
+
+    operations = [
+        migrations.RunPython(null_otp_email, migrations.RunPython.noop),
+    ]

seed/utils/organizations.py

@@ -196,4 +196,4 @@ def set_default_2fa_method(org):
     for user in org.users.iterator():
         devices = list(devices_for_user(user))
         if not devices:
-            EmailDevice.objects.create(user=user, name="default", email=user.username)
+            EmailDevice.objects.create(user=user, name="default")

seed/views/v3/two_factor_views.py

@@ -76,7 +76,7 @@ def set_method(self, request):
 
         # token_active = type(devices[0]) == Token?
         if methods.get("email") is True and not email_active:
-            email_device = EmailDevice.objects.create(user=user, name="default", email=user.username)
+            email_device = EmailDevice.objects.create(user=user, name="default")
             if email_device:
                 [device.delete() for device in devices]
                 # just for user confirmation

seed/views/v3/users.py

@@ -210,7 +210,7 @@ def create(self, request):
             user.first_name = first_name
             user.last_name = last_name
             if org.require_2fa:
-                EmailDevice.objects.create(user=user, name="default", email=user.email)
+                EmailDevice.objects.create(user=user, name="default")
         user.save()
 
         try: