Merge pull request #489 from SBNSoftware/feature/aheggest_eassignCRTPMTMatchIDinCAF_fixGP

CRTPMTMatching fix: remove unused counters

Author: ibsafa

sbncode/CAFMaker/CAFMaker_module.cc

@@ -1559,12 +1559,8 @@ void CAFMaker::produce(art::Event& evt) noexcept {
   if(crtpmtmatch_handle.isValid()){
     const std::vector<sbn::crt::CRTPMTMatching> &crtpmtmatches = *crtpmtmatch_handle;
     for (unsigned i = 0; i < crtpmtmatches.size(); i++) {
-      int topen = 0, topex = 0, sideen = 0, sideex = 0; // bottomen = 0, bottomex = 0;
       srcrtpmtmatches.emplace_back();
-      FillCRTPMTMatch(crtpmtmatches[i],
-		      topen, topex, sideen, sideex, 
-		      //bottomen, bottomex,
-		      srcrtpmtmatches.back());
+      FillCRTPMTMatch(crtpmtmatches[i], srcrtpmtmatches.back());
     }
   }
 

sbncode/CAFMaker/FillReco.cxx

@@ -141,8 +141,6 @@ namespace caf
   }
 
   void FillCRTPMTMatch(const sbn::crt::CRTPMTMatching &match,
-		       int &topen, int &topex, int &sideen, int &sideex,
-		       //int &bottomen, int &bottomex,
 		       caf::SRCRTPMTMatch &srmatch,
 		       bool allowEmpty){
     // allowEmpty does not (yet) matter here                                                           
@@ -159,6 +157,7 @@ namespace caf
     srmatch.flashPosition = SRVector3D (match.flashPosition.X(), match.flashPosition.Y(), match.flashPosition.Z());
     srmatch.flashYWidth = match.flashYWidth;
     srmatch.flashZWidth = match.flashZWidth;
+    unsigned int topen = 0, topex = 0, sideen = 0, sideex = 0;
     for(const auto& matchedCRTHit : match.matchedCRTHits){
       caf::SRMatchedCRT matchedCRT;
       matchedCRT.PMTTimeDiff = matchedCRTHit.PMTTimeDiff; 

sbncode/CAFMaker/FillReco.h

@@ -222,8 +222,6 @@ namespace caf
                   caf::SROpFlash &srflash,
                   bool allowEmpty = false);
   void FillCRTPMTMatch(const sbn::crt::CRTPMTMatching &match,
-		       int &topen, int &topex, int &sideen, int &sidex,
-		       //int &bottomen, int &bottomex,
 		       caf::SRCRTPMTMatch &srmatch,
 		       bool allowEmpty = false);