Lint: Fix RSpec/NamedSubject (#761)

Author: sunny

.rubocop_todo.yml

@@ -36,22 +36,22 @@ class Item < ActiveRecord::Base; end
 
       context "with default options" do
         describe "amount" do
-          subject { Item.columns_hash["price_cents"] }
+          let(:column) { Item.columns_hash["price_cents"] }
 
-          it { expect(subject.default.to_i).to eq(0) }
-          it { expect(Item.new.public_send(subject.name)).to eq(0) }
-          it { expect(subject.null).to be(false) }
-          it { expect(subject.type).to eq(:integer) }
+          it { expect(column.default.to_i).to eq(0) }
+          it { expect(Item.new.public_send(column.name)).to eq(0) }
+          it { expect(column.null).to be(false) }
+          it { expect(column.type).to eq(:integer) }
         end
 
         describe "currency" do
-          subject { Item.columns_hash["price_currency"] }
+          let(:column) { Item.columns_hash["price_currency"] }
 
           # set in spec/dummy/config/initializers/money.rb
-          it { expect(subject.default).to eq("EUR") }
+          it { expect(column.default).to eq("EUR") }
 
-          it { expect(subject.null).to be(false) }
-          it { expect(subject.type).to eq(:string) }
+          it { expect(column.null).to be(false) }
+          it { expect(column.type).to eq(:string) }
         end
       end
 
@@ -62,14 +62,14 @@ class Item < ActiveRecord::Base; end
 
       context "with full options" do
         describe "amount" do
-          subject { Item.columns_hash["prefix_price_with_full_options_postfix"] }
-
-          it { expect(subject.default.to_i).to eq(1) }
-          it { expect(Item.new.public_send(subject.name)).to eq(1) }
-          it { expect(subject.null).to be(true) }
-          it { expect(subject.type).to eq(:decimal) }
-          it { expect(subject.precision).to eq(4) }
-          it { expect(subject.scale).to eq(2) }
+          let(:column) { Item.columns_hash["prefix_price_with_full_options_postfix"] }
+
+          it { expect(column.default.to_i).to eq(1) }
+          it { expect(Item.new.public_send(column.name)).to eq(1) }
+          it { expect(column.null).to be(true) }
+          it { expect(column.type).to eq(:decimal) }
+          it { expect(column.precision).to eq(4) }
+          it { expect(column.scale).to eq(2) }
         end
 
         describe "currency" do

spec/active_record/migration_extensions/schema_statements_spec.rb

@@ -37,22 +37,22 @@ class Item < ActiveRecord::Base; end
 
       context "with default options" do
         describe "amount" do
-          subject { Item.columns_hash["price_cents"] }
+          let(:column) { Item.columns_hash["price_cents"] }
 
-          it { expect(subject.default.to_i).to eq(0) }
-          it { expect(Item.new.public_send(subject.name)).to eq(0) }
-          it { expect(subject.null).to be(false) }
-          it { expect(subject.type).to eq(:integer) }
+          it { expect(column.default.to_i).to eq(0) }
+          it { expect(Item.new.public_send(column.name)).to eq(0) }
+          it { expect(column.null).to be(false) }
+          it { expect(column.type).to eq(:integer) }
         end
 
         describe "currency" do
-          subject { Item.columns_hash["price_currency"] }
+          let(:column) { Item.columns_hash["price_currency"] }
 
           # set in spec/dummy/config/initializers/money.rb
-          it { expect(subject.default).to eq("EUR") }
+          it { expect(column.default).to eq("EUR") }
 
-          it { expect(subject.null).to be(false) }
-          it { expect(subject.type).to eq(:string) }
+          it { expect(column.null).to be(false) }
+          it { expect(column.type).to eq(:string) }
         end
       end
 
@@ -63,14 +63,14 @@ class Item < ActiveRecord::Base; end
 
       context "with full options" do
         describe "amount" do
-          subject { Item.columns_hash["prefix_price_with_full_options_postfix"] }
-
-          it { expect(subject.default.to_i).to eq(1) }
-          it { expect(Item.new.public_send(subject.name)).to eq(1) }
-          it { expect(subject.null).to be(true) }
-          it { expect(subject.type).to eq(:decimal) }
-          it { expect(subject.precision).to eq(4) }
-          it { expect(subject.scale).to eq(2) }
+          let(:column) { Item.columns_hash["prefix_price_with_full_options_postfix"] }
+
+          it { expect(column.default.to_i).to eq(1) }
+          it { expect(Item.new.public_send(column.name)).to eq(1) }
+          it { expect(column.null).to be(true) }
+          it { expect(column.type).to eq(:decimal) }
+          it { expect(column.precision).to eq(4) }
+          it { expect(column.scale).to eq(2) }
         end
 
         describe "currency" do

spec/active_record/migration_extensions/table_spec.rb

@@ -913,7 +913,7 @@ def assert_monetized_attributes(monetized_attributes, expected_attributes)
         end
         let(:default_currency_lambda) { double("Default Currency Fallback") }
 
-        subject { service.read_monetized(:discount, :discount_cents, options) }
+        let(:read_monetized) { service.read_monetized(:discount, :discount_cents, options) }
 
         around(:each) do |example|
           service # Instantiate instance which relies on Money.default_currency
@@ -928,7 +928,7 @@ def assert_monetized_attributes(monetized_attributes, expected_attributes)
 
           it "does not attempt to read the fallback default currency" do
             expect(default_currency_lambda).not_to receive(:read_currency)
-            subject
+            read_monetized
           end
         end
       end