FreeBSD package

[karolyi]

Hey,

if everything goes according to the plan, soon there will exist a FreeBSD packaged version of this library:

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=292270

Just leaving this information here for you. You might want to look into the diff because some changes were necessary, although it works as is now.

Cheers,
László

[lemire]

@karolyi Thanks for letting us know. I am not sure what you mean by changes but if you found issues, we would love a pull request.

[karolyi]

No bugs (none that I'm aware of at least), just a couple FreeBSD-related changes:

https://bugs.freebsd.org/bugzilla/attachment.cgi?id=266935&action=diff

Needed these in order to get the packaging and the tests running.

[lemire]

@karolyi Feel free to issue a pull request.

[karolyi]

I think that the only change that I'd add is the one that is made to portability.h, since the rest is basically using cmocka as an external dependency by pkgconfig, not sure you want that because it can break compilation on systems that don't expect to use it.

If the package gets accepted, I will make a PR of that one change, if you agree.

Also mind you that the builtin cmocka you use is outdated 1.x, 2.x is out already and is fully compatible (meaning that tests run with it), by my assessment.

[lemire]

Yes!

[karolyi]

related: manticoresoftware/manticoresearch#3783