Close and delete Intellisense database after generating project files (#566)

* Try to mitigate stalls in NativeHandles.GetAllFileHandlesAsync

* Close and delete Intellisense database after generating project files

This ensures that 'uet generate' clears out any corrupt Intellisense database files (that prevent Intellisense from working).

Author: hach-que

UET/Redpoint.Windows.HandleManagement/NativeHandles.cs

@@ -4,17 +4,18 @@
 
 namespace Redpoint.Windows.HandleManagement
 {
-    using System.ComponentModel;
-    using System.Runtime.InteropServices;
-    using System.Runtime.Versioning;
-    using System.Threading.Tasks;
+    using global::Windows.Wdk.Foundation;
+    using global::Windows.Wdk.System.SystemInformation;
     using global::Windows.Win32;
     using global::Windows.Win32.Foundation;
-    using Redpoint.Windows.VolumeManagement;
     using Redpoint.Collections;
+    using Redpoint.Windows.VolumeManagement;
+    using System.ComponentModel;
     using System.Linq;
-    using global::Windows.Wdk.System.SystemInformation;
-    using global::Windows.Wdk.Foundation;
+    using System.Runtime.InteropServices;
+    using System.Runtime.Versioning;
+    using System.Threading.Tasks;
+    using System.Xml.Linq;
 
     /// <summary>
     /// Static API methods for querying and closing handles on Windows.
@@ -240,6 +241,28 @@ internal static GetPathResultCode GetPathForHandle(SYSTEM_HANDLE targetHandle, b
                     }
                     throw new NTSTATUSException(status);
                 }
+                if (PInvoke.GetFileType((HANDLE)duplicatedHandle) != global::Windows.Win32.Storage.FileSystem.FILE_TYPE.FILE_TYPE_DISK)
+                {
+                    PInvoke.CloseHandle((HANDLE)duplicatedHandle);
+                    return GetPathResultCode.NotSupported;
+                }
+                HANDLE mapFile;
+                unsafe
+                {
+                    fixed (char* mapFileTemporaryName = "TestFileMap")
+                    {
+                        mapFile = PInvoke.CreateFileMapping((HANDLE)duplicatedHandle, null, global::Windows.Win32.System.Memory.PAGE_PROTECTION_FLAGS.PAGE_READONLY, 0, 1024, mapFileTemporaryName);
+                    }
+                }
+                if (!mapFile.IsNull)
+                {
+                    PInvoke.CloseHandle(mapFile);
+                }
+                else if (Marshal.GetLastWin32Error() == 193)
+                {
+                    PInvoke.CloseHandle((HANDLE)duplicatedHandle);
+                    return GetPathResultCode.NotSupported;
+                }
                 try
                 {
                     unsafe

UET/Redpoint.Windows.HandleManagement/NativeMethods.txt

@@ -3,4 +3,6 @@ NtQuerySystemInformation
 UNICODE_STRING
 CloseHandle
 OpenProcess
-GetCurrentProcess
+GetCurrentProcess
+GetFileType
+CreateFileMapping

UET/Redpoint.Windows.HandleManagement/NtQueryObjectPool.cs

@@ -118,10 +118,13 @@ public NTSTATUS NtQueryObject(
             {
                 // NtQueryObject has stalled. Kill the thread and restart it.
                 Debug.WriteLine($"Stalled requesting handle from process ID: {processId}");
-                cts.Cancel();
+                cts.CancelAfter(10);
                 var i = Array.IndexOf(_threads, request.Thread);
-                _threads[i] = new Thread(NtQueryObjectLoop);
-                _threads[i].Start();
+                if (i >= 0 && i < _threads.Length)
+                {
+                    _threads[i] = new Thread(NtQueryObjectLoop);
+                    _threads[i].Start();
+                }
                 returnLength = 0;
                 return (NTSTATUS)NTSTATUSException.NT_STATUS_CANCELLED;
             }

UET/uet/Commands/Generate/GenerateCommand.cs

@@ -8,6 +8,7 @@
     using Redpoint.Uet.Commands.ParameterSpec;
     using Redpoint.Uet.CommonPaths;
     using Redpoint.Uet.SdkManagement;
+    using Redpoint.Windows.HandleManagement;
     using System;
     using System.Collections.Generic;
     using System.CommandLine;
@@ -355,6 +356,52 @@ public async Task<int> ExecuteAsync(ICommandInvocationContext context)
                 if (exitCode == 0)
                 {
                     _logger.LogInformation($"Project generation finished successfully. The generated project files are located in: {outputFolder}");
+
+                    var vsDirectory = Path.Combine(workingDirectory, ".vs");
+                    if (Directory.Exists(vsDirectory))
+                    {
+                        if (OperatingSystem.IsWindowsVersionAtLeast(6, 2))
+                        {
+                            try
+                            {
+                                await foreach (var handle in NativeHandles.GetAllFileHandlesAsync(context.GetCancellationToken()))
+                                {
+                                    if (handle.FilePath.StartsWith(vsDirectory, StringComparison.OrdinalIgnoreCase) &&
+                                        (handle.FilePath.Contains("Browse.VC.db", StringComparison.OrdinalIgnoreCase) ||
+                                         handle.FilePath.Contains("Browse.VC.opendb", StringComparison.OrdinalIgnoreCase)))
+                                    {
+                                        _logger.LogInformation($"Trying to close handle to Intellisense database file at: {handle.FilePath}");
+                                        await NativeHandles.ForciblyCloseHandleAsync(handle, context.GetCancellationToken());
+                                    }
+                                }
+                            }
+                            catch
+                            {
+                            }
+                        }
+                        foreach (var browseFile in new DirectoryInfo(vsDirectory).GetFiles("Browse.VC.*db*", SearchOption.AllDirectories))
+                        {
+                            _logger.LogInformation($"Trying to clear Intellisense database file at: {browseFile.FullName}");
+                            try
+                            {
+                                browseFile.Delete();
+                            }
+                            catch
+                            {
+                            }
+                            if (browseFile.Exists)
+                            {
+                                try
+                                {
+                                    browseFile.MoveTo(browseFile.FullName + ".old");
+                                }
+                                catch
+                                {
+                                }
+                            }
+                        }
+                    }
+
                     if (open)
                     {
                         if (OperatingSystem.IsWindows())