Skip to content

Support interfaces without MAC #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rtpt-erikgeiser wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Support interfaces without MAC #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
629ee21
Support interfaces without MAC
rtpt-erikgeiser Oct 20, 2025
66670e7
Add warning about missing IPv6 relay address in verbose mode
rtpt-erikgeiser Oct 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cli.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -225,7 +225,7 @@ func (c *Config) setRedundantOptions() {
}
}

//nolint:forbidigo,maintidx,gocognit
//nolint:forbidigo,maintidx,gocognit,gocyclo
func configFromCLI() (config *Config, logger *Logger, err error) {
var (
interfaceName string
Expand Down Expand Up @@ -407,6 +407,8 @@ func configFromCLI() (config *Config, logger *Logger, err error) {

if config.RelayIPv6 == nil && config.RelayIPv4 == nil {
return config, logger, fmt.Errorf("no relay IP configured: %s and %s", errIPv4, errIPv6) //nolint:errorlint
} else if errIPv6 != nil && config.Verbose {
logger.Errorf("Warning: could not auto-detect relay IPv6 address: %v", err)
}

config.LocalIPv6, err = getLinkLocalIPv6Address(config.Interface)
Expand Down
13 changes: 7 additions & 6 deletions router_advertisement.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,12 +133,13 @@ func sendRouterAdvertisement(c *ndp.Conn, receiver netip.Addr, stateless bool, r

RouterSelectionPreference: ndp.High,
RouterLifetime: routerLifetime,
Options: []ndp.Option{
&ndp.LinkLayerAddress{
Direction: ndp.Source,
Addr: routerMAC,
},
},
}

if len(routerMAC) == 0 {
raMessage.Options = append(raMessage.Options, &ndp.LinkLayerAddress{
Direction: ndp.Source,
Addr: routerMAC,
})
}

if dnsAddr != nil {
Expand Down
Loading