Skip to content

Commit d4c15d9

Browse files
refactor: use storage key constant in tests
1 parent ba1fe8f commit d4c15d9

2 files changed

Lines changed: 6 additions & 4 deletions

File tree

tests/integration/components/new-join-steps/new-step-four-test.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ import { render } from '@ember/test-helpers';
22
import { hbs } from 'ember-cli-htmlbars';
33
import { module, test } from 'qunit';
44
import { setupRenderingTest } from 'website-www/tests/helpers';
5+
import { STEP_DATA_STORAGE_KEY } from 'website-www/constants/new-join-form';
56

67
module(
78
'Integration | Component | new-join-steps/new-step-four',
@@ -32,7 +33,7 @@ module(
3233

3334
test('it shows GitHub input when role is developer', async function (assert) {
3435
window.localStorage.setItem(
35-
'newStepOneData',
36+
STEP_DATA_STORAGE_KEY.stepOne,
3637
JSON.stringify({ role: 'Developer' }),
3738
);
3839

@@ -48,7 +49,7 @@ module(
4849

4950
test('it shows designer inputs when role is designer', async function (assert) {
5051
window.localStorage.setItem(
51-
'newStepOneData',
52+
STEP_DATA_STORAGE_KEY.stepOne,
5253
JSON.stringify({ role: 'Designer' }),
5354
);
5455

tests/integration/components/new-join-steps/new-step-one-test.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ import { hbs } from 'ember-cli-htmlbars';
1111
import Service from '@ember/service';
1212
import sinon from 'sinon';
1313
import * as RunLoop from '@ember/runloop';
14+
import { STEP_DATA_STORAGE_KEY } from '../../../../app/constants/new-join-form';
1415

1516
module(
1617
'Integration | Component | new-join-steps/new-step-one',
@@ -118,8 +119,8 @@ module(
118119

119120
await settled();
120121

121-
const raw = localStorage.getItem('newStepOneData');
122-
assert.ok(raw, 'newStepOneData saved in localStorage');
122+
const raw = localStorage.getItem(STEP_DATA_STORAGE_KEY.stepOne);
123+
assert.ok(raw, 'new step one data saved in localStorage');
123124
const parsed = JSON.parse(raw);
124125
assert.strictEqual(parsed.state, 'Karnataka', 'state persisted');
125126
assert.strictEqual(parsed.city, 'Bengaluru', 'city persisted');

0 commit comments

Comments
 (0)