Immediate Onboarding API fixes (#678)

## Status

- Closes
RaspberryPiFoundation/digital-editor-issues#1155

## What's changed?

- Verified school validation is skipped when Immediate Onboarding flag
is enabled.

---------

Co-authored-by: mwtrew <9936426+mwtrew@users.noreply.github.com>
Co-authored-by: Matthew Trew <matthew.trew@raspberrypi.org>

Author: jamiebenstead

app/models/teacher_invitation.rb

@@ -6,7 +6,7 @@ class TeacherInvitation < ApplicationRecord
   belongs_to :school
   validates :email_address,
             format: { with: EmailValidator.regexp, message: I18n.t('validations.invitation.email_address') }
-  validate :school_is_verified
+  validate :school_is_verified, unless: -> { FeatureFlags.immediate_school_onboarding? }
   after_create_commit :send_invitation_email
   encrypts :email_address
 

lib/concepts/school_student/create.rb

@@ -22,19 +22,26 @@ def create_student(school, school_student_params, token)
         password = DecryptionHelpers.decrypt_password(encrypted_password)
         name = school_student_params.fetch(:name)
 
-        validate(school:, username:, password:, name:)
+        validate(
+          username:,
+          password:,
+          name:,
+          school: (FeatureFlags.immediate_school_onboarding? ? nil : school)
+        )
 
         response = ProfileApiClient.create_school_student(token:, username:, password:, name:, school_id:)
         user_id = response[:created].first
         Role.student.create!(school:, user_id:)
         user_id
       end
 
-      def validate(school:, username:, password:, name:)
-        raise ArgumentError, 'school is not verified' unless school.verified?
+      def validate(username:, password:, name:, school: nil)
         raise ArgumentError, "username '#{username}' is invalid" if username.blank?
         raise ArgumentError, "password '#{password}' is invalid" if password.size < 8
         raise ArgumentError, "name '#{name}' is invalid" if name.blank?
+
+        return unless school
+        raise ArgumentError, 'school must be verified' unless school.verified?
       end
     end
   end

spec/concepts/school_student/create_spec.rb

@@ -77,11 +77,25 @@
   end
 
   context 'when the school is not verified' do
-    let(:school) { create(:school) }
+    let(:school) { create(:school) } # not verified by default
+
+    context 'when immediate_school_onboarding is FALSE' do
+      it 'returns the error message in the operation response' do
+        ClimateControl.modify(ENABLE_IMMEDIATE_SCHOOL_ONBOARDING: 'false') do
+          response = described_class.call(school:, school_student_params:, token:)
+          expect(response[:error]).to match(/school must be verified/)
+        end
+      end
+    end
 
-    it 'returns the error message in the operation response' do
-      response = described_class.call(school:, school_student_params:, token:)
-      expect(response[:error]).to match(/school is not verified/)
+    context 'when immediate_school_onboarding is TRUE' do
+      it 'does not error due to school verification' do
+        ClimateControl.modify(ENABLE_IMMEDIATE_SCHOOL_ONBOARDING: 'true') do
+          response = described_class.call(school:, school_student_params:, token:)
+
+          expect(response[:error]).to be_nil
+        end
+      end
     end
   end
 

spec/concepts/school_teacher/invite_spec.rb

@@ -53,9 +53,22 @@
   context 'when the school is not verified' do
     let(:school) { create(:school) }
 
-    it 'returns the error message in the operation response' do
-      response = described_class.call(school:, school_teacher_params:, token:)
-      expect(response[:error]).to match(/School is not verified/)
+    context 'when immediate_school_onboarding is FALSE' do
+      it 'does return an error message in the operation response' do
+        ClimateControl.modify(ENABLE_IMMEDIATE_SCHOOL_ONBOARDING: 'false') do
+          response = described_class.call(school:, school_teacher_params:, token:)
+          expect(response[:error]).to match(/is not verified/)
+        end
+      end
+    end
+
+    context 'when immediate_school_onboarding is TRUE' do
+      it 'does not return an error message in the operation response' do
+        ClimateControl.modify(ENABLE_IMMEDIATE_SCHOOL_ONBOARDING: 'true') do
+          response = described_class.call(school:, school_teacher_params:, token:)
+          expect(response[:error]).to be_blank
+        end
+      end
     end
   end
 end

spec/models/teacher_invitation_spec.rb

@@ -18,11 +18,22 @@
     expect(invitation).not_to be_valid
   end
 
-  it 'is invalid with an unverified school' do
-    school = build(:school, verified_at: nil)
-    invitation = build(:teacher_invitation, school:)
+  it 'is valid with an unverified school and immediate_school_onboarding is TRUE' do
+    ClimateControl.modify(ENABLE_IMMEDIATE_SCHOOL_ONBOARDING: 'true') do
+      school = build(:school, verified_at: nil)
+      invitation = build(:teacher_invitation, school:)
 
-    expect(invitation).not_to be_valid
+      expect(invitation).to be_valid
+    end
+  end
+
+  it 'is invalid with an unverified school and immediate_school_onboarding is FALSE' do
+    ClimateControl.modify(ENABLE_IMMEDIATE_SCHOOL_ONBOARDING: 'false') do
+      school = build(:school, verified_at: nil)
+      invitation = build(:teacher_invitation, school:)
+
+      expect(invitation).not_to be_valid
+    end
   end
 
   it 'sends an invitation email after create' do