Chore: eliminate build warnings

Author: jhchouuu

CMakeLists.txt

@@ -119,8 +119,8 @@ else()
 endif()
 
 add_library(mori_logging INTERFACE)
-target_include_directories(mori_logging INTERFACE include
-                                                  3rdparty/spdlog/include)
+target_include_directories(mori_logging INTERFACE include)
+target_include_directories(mori_logging SYSTEM INTERFACE 3rdparty/spdlog/include)
 
 if(ENABLE_PROFILER)
   find_package(

src/io/xgmi/backend_impl.cpp

@@ -269,7 +269,10 @@ XgmiBackend::~XgmiBackend() {
   std::unique_lock<std::shared_mutex> lock(ipcMutex);
   for (auto& entry : remoteIpcHandles) {
     if (entry.second.remappedAddr != nullptr) {
-      hipIpcCloseMemHandle(entry.second.remappedAddr);
+      hipError_t closeErr = hipIpcCloseMemHandle(entry.second.remappedAddr);
+      if (closeErr != hipSuccess) {
+        MORI_IO_WARN("XGMI: Failed to close IPC mem handle: {}", hipGetErrorString(closeErr));
+      }
     }
   }
   remoteIpcHandles.clear();
@@ -309,7 +312,10 @@ void XgmiBackend::InitializeP2PAccess() {
       if (canAccess) {
         hipError_t enableErr = hipDeviceEnablePeerAccess(j, 0);
         if (enableErr == hipErrorPeerAccessAlreadyEnabled) {
-          hipGetLastError();
+          hipError_t clearErr = hipGetLastError();
+          if (clearErr != hipSuccess) {
+            MORI_IO_WARN("XGMI: Failed to clear peer access error: {}", hipGetErrorString(clearErr));
+          }
           p2pMatrix[i][j] = true;
           MORI_IO_TRACE("XGMI: P2P access already enabled from device {} to {}", i, j);
         } else if (enableErr != hipSuccess) {
@@ -401,7 +407,10 @@ void* XgmiBackend::GetRemappedAddress(const MemoryDesc& desc, int localDeviceId)
   void* remappedAddr = nullptr;
   err = hipIpcOpenMemHandle(&remappedAddr, handle, hipIpcMemLazyEnablePeerAccess);
   if (err != hipSuccess) {
-    hipGetLastError();
+    hipError_t clearErr = hipGetLastError();
+    if (clearErr != hipSuccess) {
+      MORI_IO_WARN("XGMI: Failed to clear IPC open error: {}", hipGetErrorString(clearErr));
+    }
     if (IsP2PAccessible(localDeviceId, desc.deviceId)) {
       MORI_IO_TRACE("XGMI: IPC failed, using direct P2P pointer for id={}", desc.id);
       return reinterpret_cast<void*>(desc.data);

src/io/xgmi/hip_resource_pool.cpp

@@ -88,7 +88,10 @@ bool StreamPool::InitializeStreamsForDevice(int deviceId) {
       MORI_IO_ERROR("StreamPool: Failed to create stream for device {}: {}", deviceId,
                     hipGetErrorString(err));
       for (auto s : deviceStreams) {
-        hipStreamDestroy(s);
+        hipError_t destroyErr = hipStreamDestroy(s);
+        if (destroyErr != hipSuccess) {
+          MORI_IO_ERROR("StreamPool: Failed to destroy stream: {}", hipGetErrorString(destroyErr));
+        }
       }
       return false;
     }
@@ -117,7 +120,10 @@ EventPool::~EventPool() {
       hipEvent_t event = deviceEntry.second.front();
       deviceEntry.second.pop();
       if (event != nullptr) {
-        hipEventDestroy(event);
+        hipError_t destroyErr = hipEventDestroy(event);
+        if (destroyErr != hipSuccess) {
+          MORI_IO_ERROR("EventPool: Failed to destroy event: {}", hipGetErrorString(destroyErr));
+        }
       }
     }
   }