chore: address copilot review round 2

Author: RMCampos

server/src/main/java/br/com/tasknoteapp/server/repository/NoteRepository.java

@@ -13,6 +13,8 @@ public interface NoteRepository extends JpaRepository<NoteEntity, Long> {
 
   Optional<NoteEntity> findByShareToken(String shareToken);
 
+  Optional<NoteEntity> findByIdAndUser_id(Long id, Long userId);
+
   @Query(
       "select n from NoteEntity n where (upper(n.title) like %?1% or upper(n.description) like"
           + " %?1%) and n.user.id = ?2")

server/src/main/java/br/com/tasknoteapp/server/service/NoteService.java

@@ -138,15 +138,12 @@ public NoteResponse patchNote(Long noteId, NotePatchRequest patch) {
 
     logger.info("Patching task " + noteId + " to user " + user.getId());
 
-    Optional<NoteEntity> note = noteRepository.findById(noteId);
+    Optional<NoteEntity> note = noteRepository.findByIdAndUser_id(noteId, user.getId());
     if (note.isEmpty()) {
       throw new NoteNotFoundException();
     }
 
     NoteEntity noteEntity = note.get();
-    if (!noteEntity.getUser().getId().equals(user.getId())) {
-      throw new NoteNotFoundException();
-    }
     if (!Objects.isNull(patch.title()) && !patch.title().isBlank()) {
       noteEntity.setTitle(patch.title().trim());
     }
@@ -187,17 +184,13 @@ public void deleteNote(Long noteId) {
 
     logger.info("Deleting note " + noteId + " to user " + user.getId());
 
-    Optional<NoteEntity> note = noteRepository.findById(noteId);
+    Optional<NoteEntity> note = noteRepository.findByIdAndUser_id(noteId, user.getId());
     if (note.isEmpty()) {
       throw new NoteNotFoundException();
     }
 
     NoteEntity noteEntity = note.get();
 
-    if (!noteEntity.getUser().getId().equals(user.getId())) {
-      throw new NoteNotFoundException();
-    }
-
     noteUrlRepository.deleteByNote_id(noteId);
     logger.info("URL deleted from task " + noteId);
 
@@ -229,21 +222,18 @@ public List<NoteResponse> searchNotes(String searchTerm) {
    * @param noteId The note id from the database.
    * @return {@link NoteResponse} containing the updated note with share token.
    */
+  @Transactional
   public NoteResponse shareNote(Long noteId) {
     UserEntity user = getCurrentUser();
     logger.info("Sharing note " + noteId + " for user " + user.getId());
 
-    Optional<NoteEntity> noteOpt = noteRepository.findById(noteId);
+    Optional<NoteEntity> noteOpt = noteRepository.findByIdAndUser_id(noteId, user.getId());
     if (noteOpt.isEmpty()) {
       throw new NoteNotFoundException();
     }
 
     NoteEntity noteEntity = noteOpt.get();
 
-    if (!noteEntity.getUser().getId().equals(user.getId())) {
-      throw new NoteNotFoundException();
-    }
-
     if (!noteEntity.isShared()) {
       noteEntity.setShared(true);
       noteEntity.setShareToken(UUID.randomUUID().toString());
@@ -264,15 +254,12 @@ public NoteResponse unshareNote(Long noteId) {
     UserEntity user = getCurrentUser();
     logger.info("Unsharing note " + noteId + " for user " + user.getId());
 
-    Optional<NoteEntity> noteOpt = noteRepository.findById(noteId);
+    Optional<NoteEntity> noteOpt = noteRepository.findByIdAndUser_id(noteId, user.getId());
     if (noteOpt.isEmpty()) {
       throw new NoteNotFoundException();
     }
 
     NoteEntity noteEntity = noteOpt.get();
-    if (!noteEntity.getUser().getId().equals(user.getId())) {
-      throw new NoteNotFoundException();
-    }
     noteEntity.setShared(false);
     noteEntity.setShareToken(null);
     noteRepository.save(noteEntity);
@@ -310,6 +297,9 @@ private String getNoteUrl(Long noteId) {
 
   private List<NoteResponse> getNotesUrl(List<NoteEntity> notes) {
     List<Long> noteIds = notes.stream().map(NoteEntity::getId).toList();
+    if (noteIds.isEmpty()) {
+      return notes.stream().map(n -> NoteResponse.fromEntity(n, null)).toList();
+    }
     List<NoteUrlEntity> urls = noteUrlRepository.findAllByNote_idIn(noteIds);
     Map<Long, String> noteUrls =
         urls.stream().collect(Collectors.toMap(nu -> nu.getNote().getId(), NoteUrlEntity::getUrl));