Skip to content

Commit 5b8e2b4

Browse files
committed
fix: update null handling
1 parent 724e371 commit 5b8e2b4

1 file changed

Lines changed: 5 additions & 6 deletions

File tree

src/tera_extension.cpp

Lines changed: 5 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,10 @@ unique_ptr<FunctionData> TeraRenderBind(ClientContext &context, ScalarFunction &
9090

9191
const auto list_children = ListValue::GetChildren(ExpressionExecutor::EvaluateScalar(context, *arg));
9292
for (const auto &list_item : list_children) {
93-
// These should also be lists.
9493
if (list_item.type() != LogicalType::VARCHAR) {
95-
throw BinderException(
96-
StringUtil::Format("tera_render: 'autoescape_on' child must be a string it is %s value is %s",
97-
list_item.type().ToString(), list_item.ToString()));
94+
throw BinderException(StringUtil::Format(
95+
"tera_render: 'autoescape_extensions' elements must be strings, got %s with value %s",
96+
list_item.type().ToString(), list_item.ToString()));
9897
}
9998

10099
autoescape_on.push_back(list_item.GetValue<string>());
@@ -167,14 +166,14 @@ static void LoadInternal(ExtensionLoader &loader) {
167166
auto render_with_context =
168167
ScalarFunction({LogicalType::VARCHAR, LogicalType::JSON()}, LogicalType::VARCHAR, TeraRenderFunc,
169168
TeraRenderBind, nullptr, nullptr, nullptr, LogicalType(LogicalTypeId::ANY));
170-
render_with_context.null_handling = FunctionNullHandling::SPECIAL_HANDLING;
169+
render_with_context.null_handling = FunctionNullHandling::DEFAULT_NULL_HANDLING;
171170
render_with_context.stability = FunctionStability::VOLATILE;
172171
render.AddFunction(render_with_context);
173172

174173
auto render_no_context =
175174
ScalarFunction({LogicalType::VARCHAR}, LogicalType::VARCHAR, TeraRenderFunc, TeraRenderBind, nullptr,
176175
nullptr, nullptr, LogicalType(LogicalTypeId::ANY));
177-
render_no_context.null_handling = FunctionNullHandling::SPECIAL_HANDLING;
176+
render_no_context.null_handling = FunctionNullHandling::DEFAULT_NULL_HANDLING;
178177
render_no_context.stability = FunctionStability::VOLATILE;
179178
render.AddFunction(render_no_context);
180179

0 commit comments

Comments
 (0)