Skip to content

Conversation

@kshyatt
Copy link
Member

@kshyatt kshyatt commented Jan 21, 2026

Added more tests to test_pullbacks_match to make sure the state of the arguments is restored, and the final argument derivatives match between inplace and non in place methods.

Unfortunately, the Mooncake FD tester doesn't work well for our functions, because A becomes a scratch space, and the inputs are also the outputs (so get incremented twice under the FD scheme).

@kshyatt
Copy link
Member Author

kshyatt commented Jan 21, 2026

I'd like to do a bit of tidying up with this one but it can be merged if tests pass and people feel like it, I can just make a separate PR.

@kshyatt kshyatt requested review from Jutho and lkdvos January 21, 2026 19:40
@codecov
Copy link

codecov bot commented Jan 21, 2026

Codecov Report

❌ Patch coverage is 5.26316% with 108 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...gebraKitMooncakeExt/MatrixAlgebraKitMooncakeExt.jl 5.26% 108 Missing ⚠️
Files with missing lines Coverage Δ
...gebraKitMooncakeExt/MatrixAlgebraKitMooncakeExt.jl 16.91% <5.26%> (-82.22%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants