Switch to mypy

This is a work-in-progress attempt at switching over to mypy as part of
 #85. There's still some work to be done (e.g. mypy ignore comments need
to be added where appropriate) and I'm currently working with some
local changes pyre's stubs, but I wanted to track the work being done.

Author: dirn

src/.coveragerc .coveragercsrc/.coveragerc renamed to .coveragerc

@@ -29,7 +29,6 @@ indent_style = space
 atomic = true
 force_sort_within_sections = true
 include_trailing_comma = true
-known_third_party = decouple,django,factory,pytest,sesame
 multi_line_output = 3
 
 [.pyre_configuration]

.editorconfig

@@ -4,20 +4,5 @@ ignore = E203, E231, E266, E501, W503
 max-line-length = 80
 max-complexity = 18
 per-file-ignores =
-    src/awards/settings/dev.py: F405
-    # TODO: Remove these once
-    # https://github.com/facebook/pyre-check/pull/256,
-    # https://github.com/facebook/pyre-check/pull/260,
-    # https://github.com/facebook/pyre-check/pull/261, and
-    # https://github.com/facebook/pyre-check/pull/262 can be used.
-    src/applications/forms.py: B950
-    src/applications/migrations/0003_auto_20200507_0125.py: B950
-    src/applications/models.py: B950
-    src/applications/test_views.py: B950
-    src/awards/urls.py: B950
-    src/homepage/test_views.py: B950
-    src/users/migrations/0001_initial.py: B950
-    src/users/forms.py: B950
-    src/users/models.py: B950
-    src/users/views.py: B950
+    awards/settings/dev.py: F405
 select = B,C,E,F,W,T4,B9

.flake8

@@ -30,11 +30,6 @@ repos:
     hooks:
       - id: autoflake
         args: ['--in-place', '--remove-all-unused-imports', '--remove-unused-variable']
-  - repo: https://github.com/asottile/seed-isort-config
-    rev: v2.2.0
-    hooks:
-      - id: seed-isort-config
-        args: ['--application-directories=src']
   - repo: https://github.com/timothycrosley/isort
     rev: 5.6.4
     hooks:

.pre-commit-config.yaml

@@ -70,7 +70,7 @@ environment. It can be output without running the unit tests with::
 Type checks
 -----------
 
-The type checks are done using pyre_ and can be run with::
+The type checks are done using Mypy_ and can be run with::
 
     $ tox -e types
 
@@ -128,9 +128,9 @@ will be removed from the repository.
 .. _citext: https://www.postgresql.org/docs/current/citext.html
 .. _Hacktoberfest: https://hacktoberfest.digitalocean.com
 .. _ipython: https://ipython.readthedocs.io
+.. _Mypy: https://mypy.readthedocs.io
 .. _PostgreSQL: https://www.postgresql.org
 .. _psql: https://www.postgresql.org/docs/current/app-psql.html
-.. _pyre: https://pyre-check.org
 .. _tox: https://tox.readthedocs.io
 .. _watchman: https://facebook.github.io/watchman/
 

README.rst

@@ -17,7 +17,6 @@ class FinancialAidApplicationForm(ApplicationForm):
     type = Application.Type.FINANCIAL_AID
 
     travel_requested = forms.BooleanField(
-        # pyre-ignore[16]: This is fixed by https://github.com/facebook/pyre-check/pull/262.
         label=_("Do you need assistance with travel?"),
         required=False,
     )
@@ -32,13 +31,9 @@ class Meta:
             "lodging_requested",
         )
         labels = {
-            # pyre-ignore[16]: This is fixed by https://github.com/facebook/pyre-check/pull/262.
             "background": _("Tell us a little bit more about yourself"),
-            # pyre-ignore[16]: This is fixed by https://github.com/facebook/pyre-check/pull/262.
             "lodging_requested": _("Do you need assistance with lodging?"),
-            # pyre-ignore[16]: This is fixed by https://github.com/facebook/pyre-check/pull/262.
             "reason_to_attend": _("Why are you interested in attending PyGotham?"),
-            # pyre-ignore[16]: This is fixed by https://github.com/facebook/pyre-check/pull/262.
             "travel_amount": _("What is the estimated cost (USD)?"),
         }
         widgets = {
@@ -51,39 +46,28 @@ def clean(self) -> Dict[str, Any]:
         travel_amount = cleaned_data.get("travel_amount") or 0
         if travel_amount < 0:
             raise forms.ValidationError(
-                {
-                    # pyre-ignore[16]: This is fixed by https://github.com/facebook/pyre-check/pull/262.
-                    "travel_amount": _(
-                        "Your estimated travel costs cannot be negative."
-                    )
-                }
+                {"travel_amount": _("Your estimated travel costs cannot be negative.")}
             )
 
         travel_requested = cleaned_data.get("travel_requested")
         if travel_requested:
             if not travel_amount:
                 raise forms.ValidationError(
                     {
-                        # pyre-ignore[16]: This is fixed by https://github.com/facebook/pyre-check/pull/262.
                         "travel_amount": _(
                             "Your estimated travel costs must be greater than $0.00."
                         )
                     }
                 )
         elif travel_amount:
-            raise forms.ValidationError(
-                {
-                    # pyre-ignore[16]: This is fixed by https://github.com/facebook/pyre-check/pull/262.
-                    "travel_requested": _(
-                        "You must request travel assistance before providing an estimated cost."
-                    )
-                }
+            msg = _(
+                "You must request travel assistance before providing an estimated cost."
             )
+            raise forms.ValidationError({"travel_requested": msg})
 
         return cleaned_data
 
     def clean_lodging_requested(self) -> bool:
-        # pyre-ignore[16]: This is fixed by https://github.com/facebook/pyre-check/pull/261.
         return bool(self.cleaned_data.get("lodging_requested"))
 
 
@@ -94,9 +78,7 @@ class Meta:
         model = Application
         fields = ("background", "reason_to_attend")
         labels = {
-            # pyre-ignore[16]: This is fixed by https://github.com/facebook/pyre-check/pull/262.
             "background": _("Tell us a little bit about yourself"),
-            # pyre-ignore[16]: This is fixed by https://github.com/facebook/pyre-check/pull/262.
             "reason_to_attend": _("Why are you interested in attending PyGotham?"),
         }