-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Open
Labels
featureNew feature or requestNew feature or request
Description
π Feature
Stress-tests show that we frequently don't sign future batch proposals because they're for a future round. We should investigate if we can get rid of this code:
- // If the signed round is ahead of the peer's batch round, do not sign the proposal.
- // Note: while this may be valid behavior, additional formal analysis and testing will need to be done before allowing it.
- if signed_round > batch_header.round() {
- bail!(
- "Peer ({batch_author}) proposed a batch for a previous round ({}), latest signed round: {signed_round}",
- batch_header.round()
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
featureNew feature or requestNew feature or request