Skip to content

Commit 550cc4f

Browse files
refactor: replace null coalescing operator with ternary for consistent value setting
1 parent ddc5cca commit 550cc4f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

src/Components/Filters/FilterEnumSelect.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public function dataSource(Collection|array $enumCases): FilterEnumSelect
2424
public function execute(): FilterEnumSelect
2525
{
2626
// use previously set optionLabel is set by the user
27-
$optionLabel = $this->optionLabel ?? 'value';
27+
$optionLabel = $this->optionLabel ?: 'value';
2828

2929
$collection = collect($this->dataSource)->map(function ($case) use (&$optionLabel) {
3030
$option = (array) $case;

src/Concerns/Filter.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -513,11 +513,11 @@ public function listColumnForQueryString(): Collection
513513
collect($this->columns())
514514
->ensure([Column::class])
515515
->each(function ($column) use (&$columns) {
516-
if (isset($column->dataField)) {
517-
$columns->put($column->dataField, $column->title ?? $column->dataField);
516+
if (filled($column->dataField)) {
517+
$columns->put($column->dataField, $column->title ?: $column->dataField);
518518
}
519519

520-
$columns->put($column->field, $column->title ?? $column->field);
520+
$columns->put($column->field, $column->title ?: $column->field);
521521
});
522522

523523
return $columns;

0 commit comments

Comments
 (0)