Consolidate relation__ and routine__ test suites

Merge 8 single-function test files into 2 combined suites to reduce
repeated setup and keep related tests together:

- relation__.sql: relation_type + is_temp + is_catalog + column_names (41 tests)
- routine__.sql: routine_type + argument_mode + volatility + parallel_safety (57 tests)

Rename conflicting temp table names (test_temp_table → is_temp_test /
is_catalog_test) to avoid collision within the merged relation__ suite.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: jnasbyupgrade

test/expected/relation_type.out test/expected/relation__.outtest/expected/relation_type.out renamed to test/expected/relation__.out

@@ -1,5 +1,5 @@
 \set ECHO none
-1..23
+1..41
 ok 1 - Verify count from kinds
 ok 2 - Simple sanity check of relation__kind()
 ok 3 - Simple sanity check of relation__relkind()
@@ -23,4 +23,22 @@ ok 20 - SELECT cat_tools.relation_type('f')
 ok 21 - SELECT cat_tools.relation_type('m')
 ok 22 - SELECT cat_tools.relation_type('p')
 ok 23 - SELECT cat_tools.relation_type('I')
+ok 24 - Verify public has no perms
+ok 25 - pg_catalog.pg_class is not a temp relation
+ok 26 - Create temp table for testing
+ok 27 - temp relation is correctly identified as temp
+ok 28 - NULL input returns NULL (STRICT function)
+ok 29 - Verify public has no perms
+ok 30 - pg_catalog.pg_class is in pg_catalog schema
+ok 31 - Create temp table for testing
+ok 32 - temp relation is not in pg_catalog schema
+ok 33 - NULL input returns NULL (STRICT function)
+ok 34 - Verify public has no perms
+ok 35 - Create temp table with multiple columns
+ok 36 - Temp table returns expected column names
+ok 37 - Drop middle column from temp table
+ok 38 - Temp table with dropped column returns expected column names
+ok 39 - Create test table with columns
+ok 40 - Test table returns expected column names
+ok 41 - NULL input returns NULL (STRICT function)
 # TRANSACTION INTENTIONALLY LEFT OPEN!

test/expected/relation__column_names.out

@@ -0,0 +1,60 @@
+\set ECHO none
+1..57
+ok 1 - Verify count from routine_kinds
+ok 2 - Simple sanity check of routine__type()
+ok 3 - Simple sanity check of routine__type() with enum
+ok 4 - SELECT cat_tools.routine__type('f'::cat_tools.routine_prokind)
+ok 5 - SELECT cat_tools.routine__type('p'::cat_tools.routine_prokind)
+ok 6 - SELECT cat_tools.routine__type('a'::cat_tools.routine_prokind)
+ok 7 - SELECT cat_tools.routine__type('w'::cat_tools.routine_prokind)
+ok 8 - SELECT cat_tools.routine__type('f'::"char")
+ok 9 - SELECT cat_tools.routine__type('p'::"char")
+ok 10 - SELECT cat_tools.routine__type('a'::"char")
+ok 11 - SELECT cat_tools.routine__type('w'::"char")
+ok 12 - SELECT cat_tools.routine__type('f')
+ok 13 - SELECT cat_tools.routine__type('p')
+ok 14 - SELECT cat_tools.routine__type('a')
+ok 15 - SELECT cat_tools.routine__type('w')
+ok 16 - Verify count from argument_modes
+ok 17 - Simple sanity check of routine__argument_mode()
+ok 18 - Simple sanity check of routine__argument_mode() with enum
+ok 19 - SELECT cat_tools.routine__argument_mode('i'::cat_tools.routine_proargmode)
+ok 20 - SELECT cat_tools.routine__argument_mode('o'::cat_tools.routine_proargmode)
+ok 21 - SELECT cat_tools.routine__argument_mode('b'::cat_tools.routine_proargmode)
+ok 22 - SELECT cat_tools.routine__argument_mode('v'::cat_tools.routine_proargmode)
+ok 23 - SELECT cat_tools.routine__argument_mode('t'::cat_tools.routine_proargmode)
+ok 24 - SELECT cat_tools.routine__argument_mode('i'::"char")
+ok 25 - SELECT cat_tools.routine__argument_mode('o'::"char")
+ok 26 - SELECT cat_tools.routine__argument_mode('b'::"char")
+ok 27 - SELECT cat_tools.routine__argument_mode('v'::"char")
+ok 28 - SELECT cat_tools.routine__argument_mode('t'::"char")
+ok 29 - SELECT cat_tools.routine__argument_mode('i')
+ok 30 - SELECT cat_tools.routine__argument_mode('o')
+ok 31 - SELECT cat_tools.routine__argument_mode('b')
+ok 32 - SELECT cat_tools.routine__argument_mode('v')
+ok 33 - SELECT cat_tools.routine__argument_mode('t')
+ok 34 - Verify count from volatilities
+ok 35 - Simple sanity check of routine__volatility()
+ok 36 - Simple sanity check of routine__volatility() with enum
+ok 37 - SELECT cat_tools.routine__volatility('i'::cat_tools.routine_provolatile)
+ok 38 - SELECT cat_tools.routine__volatility('s'::cat_tools.routine_provolatile)
+ok 39 - SELECT cat_tools.routine__volatility('v'::cat_tools.routine_provolatile)
+ok 40 - SELECT cat_tools.routine__volatility('i'::"char")
+ok 41 - SELECT cat_tools.routine__volatility('s'::"char")
+ok 42 - SELECT cat_tools.routine__volatility('v'::"char")
+ok 43 - SELECT cat_tools.routine__volatility('i')
+ok 44 - SELECT cat_tools.routine__volatility('s')
+ok 45 - SELECT cat_tools.routine__volatility('v')
+ok 46 - Verify count from parallel_safeties
+ok 47 - Simple sanity check of routine__parallel_safety()
+ok 48 - Simple sanity check of routine__parallel_safety() with enum
+ok 49 - SELECT cat_tools.routine__parallel_safety('s'::cat_tools.routine_proparallel)
+ok 50 - SELECT cat_tools.routine__parallel_safety('r'::cat_tools.routine_proparallel)
+ok 51 - SELECT cat_tools.routine__parallel_safety('u'::cat_tools.routine_proparallel)
+ok 52 - SELECT cat_tools.routine__parallel_safety('s'::"char")
+ok 53 - SELECT cat_tools.routine__parallel_safety('r'::"char")
+ok 54 - SELECT cat_tools.routine__parallel_safety('u'::"char")
+ok 55 - SELECT cat_tools.routine__parallel_safety('s')
+ok 56 - SELECT cat_tools.routine__parallel_safety('r')
+ok 57 - SELECT cat_tools.routine__parallel_safety('u')
+# TRANSACTION INTENTIONALLY LEFT OPEN!

test/expected/relation__is_catalog.out

@@ -0,0 +1,179 @@
+\set ECHO none
+
+\i test/setup.sql
+
+SET LOCAL ROLE :use_role;
+CREATE TEMP VIEW kinds AS
+  SELECT
+      (cat_tools.enum_range('cat_tools.relation_type'))[gs] AS kind
+      , (cat_tools.enum_range('cat_tools.relation_relkind'))[gs] AS relkind
+    FROM generate_series(
+      1
+      , greatest(
+        array_upper(cat_tools.enum_range('cat_tools.relation_type'), 1)
+        , array_upper(cat_tools.enum_range('cat_tools.relation_relkind'), 1)
+      )
+    ) gs
+;
+
+SELECT plan(
+  (1 + 2 + 2 * (SELECT count(*)::int FROM kinds)) -- relation_type enum mapping
+  + 5 -- relation__is_temp
+  + 5 -- relation__is_catalog
+  + 8 -- relation__column_names
+);
+
+-- relation_type enum mapping
+SELECT is(
+  (SELECT count(*)::int FROM kinds)
+  , 10
+  , 'Verify count from kinds'
+);
+
+SELECT is(
+  cat_tools.relation__kind('r')
+  , 'table'
+  , 'Simple sanity check of relation__kind()'
+);
+SELECT is(
+  cat_tools.relation__relkind('table')
+  , 'r'
+  , 'Simple sanity check of relation__relkind()'
+);
+
+SELECT is(cat_tools.relation__relkind(kind)::text, relkind, format('SELECT cat_tools.relation_relkind(%L)', kind))
+  FROM kinds
+;
+
+SELECT is(cat_tools.relation__kind(relkind)::text, kind, format('SELECT cat_tools.relation_type(%L)', relkind))
+  FROM kinds
+;
+
+-- relation__is_temp
+\set s cat_tools
+\set f relation__is_temp
+
+SET LOCAL ROLE :no_use_role;
+
+SELECT throws_ok(
+  format(
+    $$SELECT %I.%I( %L )$$
+    , :'s', :'f'
+    , 'pg_catalog.pg_class'
+  )
+  , '42501'
+  , NULL
+  , 'Verify public has no perms'
+);
+
+SET LOCAL ROLE :use_role;
+
+SELECT is(
+  cat_tools.relation__is_temp('pg_catalog.pg_class'::regclass)
+  , false
+  , 'pg_catalog.pg_class is not a temp relation'
+);
+
+SELECT lives_ok($$CREATE TEMP TABLE is_temp_test()$$, 'Create temp table for testing');
+
+SELECT is(
+  cat_tools.relation__is_temp('is_temp_test'::regclass)
+  , true
+  , 'temp relation is correctly identified as temp'
+);
+
+SELECT is(
+  cat_tools.relation__is_temp(NULL)
+  , NULL
+  , 'NULL input returns NULL (STRICT function)'
+);
+
+-- relation__is_catalog
+\set f relation__is_catalog
+
+SET LOCAL ROLE :no_use_role;
+
+SELECT throws_ok(
+  format(
+    $$SELECT %I.%I( %L )$$
+    , :'s', :'f'
+    , 'pg_catalog.pg_class'
+  )
+  , '42501'
+  , NULL
+  , 'Verify public has no perms'
+);
+
+SET LOCAL ROLE :use_role;
+
+SELECT is(
+  cat_tools.relation__is_catalog('pg_catalog.pg_class'::regclass)
+  , true
+  , 'pg_catalog.pg_class is in pg_catalog schema'
+);
+
+SELECT lives_ok($$CREATE TEMP TABLE is_catalog_test()$$, 'Create temp table for testing');
+
+SELECT is(
+  cat_tools.relation__is_catalog('is_catalog_test'::regclass)
+  , false
+  , 'temp relation is not in pg_catalog schema'
+);
+
+SELECT is(
+  cat_tools.relation__is_catalog(NULL)
+  , NULL
+  , 'NULL input returns NULL (STRICT function)'
+);
+
+-- relation__column_names
+\set f relation__column_names
+
+SET LOCAL ROLE :no_use_role;
+
+SELECT throws_ok(
+  format(
+    $$SELECT %I.%I( %L )$$
+    , :'s', :'f'
+    , 'temp_test_table'
+  )
+  , '42501'
+  , NULL
+  , 'Verify public has no perms'
+);
+
+SET LOCAL ROLE :use_role;
+
+SELECT lives_ok($$CREATE TEMP TABLE temp_test_table(col1 int, col2 text, col3 boolean, col4 timestamp, col5 numeric)$$, 'Create temp table with multiple columns');
+
+SELECT is(
+  cat_tools.relation__column_names('temp_test_table'::regclass)
+  , '{col1,col2,col3,col4,col5}'::text[]
+  , 'Temp table returns expected column names'
+);
+
+SELECT lives_ok($$ALTER TABLE temp_test_table DROP COLUMN col3$$, 'Drop middle column from temp table');
+
+SELECT is(
+  cat_tools.relation__column_names('temp_test_table'::regclass)
+  , '{col1,col2,col4,col5}'::text[]
+  , 'Temp table with dropped column returns expected column names'
+);
+
+SELECT lives_ok($$CREATE TEMP TABLE test_table(id int, name text)$$, 'Create test table with columns');
+
+SELECT is(
+  cat_tools.relation__column_names('test_table'::regclass)
+  , '{id,name}'::text[]
+  , 'Test table returns expected column names'
+);
+
+SELECT is(
+  cat_tools.relation__column_names(NULL)
+  , NULL
+  , 'NULL input returns NULL (STRICT function)'
+);
+
+\i test/pgxntool/finish.sql
+
+-- vi: expandtab ts=2 sw=2