upgrade from Piwigo is broken

[plegall]

In the main.inc.php file, for a few revisions now, I see 2 problems:

1. the Version: 1.5.6 is not always accurate (piwigo.org/ext says revision 1.5.5 but we find 1.5.3 in the file :-/
2. the Plugin URI: auto stays like this in the build, which makes auto-update impossible from Piwigo

My recommendation is to change the way you publish new revisions of the plugin:

1. change to Version: auto
2. use the "Git" option to generate the build :

... this will automatically rewrite the version and URI 👌

[samwilson]

It's up to version 2.0.1 now, and the version number in there should be correct.

I'd use the Git option in the extension manager, but unfortunately that doesn't work because it doesn't pull the Composer dependencies. Hence building it manually and uploading a zip file.

What should Plugin URI be set to?

[plegall]

I'd use the Git option in the extension manager, but unfortunately that doesn't work because it doesn't pull the Composer dependencies. Hence building it manually and uploading a zip file.

OK, I understand. I don't like the fact that if you build a new revision at 1pm and at 2pm you won't get the same thing in your zip archive. But hey, that's the way Composer works, right?

What should Plugin URI be set to?

http://piwigo.org/ext/extension_view.php?eid=612

[samwilson]

I don't like the fact that if you build a new revision at 1pm and at 2pm you won't get the same thing in your zip archive. But hey, that's the way Composer works, right?

Do you mean if you run composer update between the builds?

But yeah in general it'd be better to automate the composer step somehow so that people don't have to trust that I or any maintainer has run the build correctly. I could set it up to build on GitHub and then use the "Download from URL" option, would that work? At least then the build config would be public. That'd involve enabling Actions on this repo.

[samwilson]

http://piwigo.org/ext/extension_view.php?eid=612 redirects to https://piwigo.org/ext/index.php?eid=612 should I use that instead?

[plegall]

No, use the one I gave ;-) we're going to fix that, but for now the URI must include extension_view.php?eid=, see https://github.com/Piwigo/Piwigo/blob/master/admin/include/plugins.class.php#L393

[samwilson]

Ah, understood! Done. :-)

And what do you think about what I said above about setting up an automatic zip-building process for this repo?

[samwilson]

I've released 2.0.2 with the new Plugin URI value.

[plegall]

Ah, understood! Done. :-)

👍

And what do you think about what I said above about setting up an automatic zip-building process for this repo?

I can see in your README :

2. Run composer update --no-dev -o to get the vendor/ directory prepared.

I'm not a user of composer, so I need to better understand what it implies here. Would that be a valid command for any plugin/theme to build in Piwigo extension manager?

[samwilson]

Would that be a valid command for any plugin/theme to build in Piwigo extension manager?

Yes, definitely. If you could run composer install --no-dev for any plugin that has a composer.lock file that'd work, as far as I can see. (The instructions above use update but it would be safer to only use pinned versions, which is what install does.)