Patching instructions in Ares with Patch class

[tyuah8]

I noticed that Phobos uses the Patch class and the methods it provides in order to patch some instructions in Ares, but the patching capabilities seem to be limited.

Through my own experimentation, I found that methods like Patch::Apply_LJMP() or Patch::Apply_CALL() don't seem to always "work". Sometimes, it is as though the patching fails, but no error returns. For example, patching the beginning of a function with Patch::Apply_LJMP() "works", but a more "complex" patch which attempts to implement an arbitrary "hook" to jump into Phobos code, from an arbitrary location in Ares, before returning back to Ares, doesn't always "work". When it doesn't "work", precisely "nothing" happens, as though the patch isn't even there.

Would anyone here happen to know why this behaviour happens?

[Metadorius]

seems weird to me, but also sounds like even more of a reason to implement DLL hooks into Syringe, like

DEFINE_DLL_HOOK_AGAIN(fingerprint, addr, name, stolen_bytes)
DEFINE_DLL_HOOK(fingerprint, addr, name, stolen_bytes)

where fingerprint is something that uniquely identifies a specific DLL, like checksum or something

[tyuah8]

seems weird to me, but also sounds like even more of a reason to implement DLL hooks into Syringe, like

DEFINE_DLL_HOOK_AGAIN(fingerprint, addr, name, stolen_bytes)
DEFINE_DLL_HOOK(fingerprint, addr, name, stolen_bytes)

where fingerprint is something that uniquely identifies a specific DLL, like checksum or something

I figured it out. It is a really silly mistake on my end. I basically patched code in Ares that was inside some if statement body, where the condition of that if statement was false, so the body containing the patched code was never being reached. After I corrected this, it is now being reached.

Sorry for the mistake!