v3.2.5

PaulLeCam · PaulLeCam · commit ca1e765ed328 · 2022-01-15T10:32:17.000Z
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,7 @@
+## v3.2.5 (2022-01-15)
+
+Fix supporting mutable `whenCreated` with unmounting `MapContainer`.
+
 ## v3.2.4 (2022-01-09)
 
 Fix removing the map handlers when `MapContainer` is unmounted.
diff --git a/packages/react-leaflet/package.json b/packages/react-leaflet/package.json
@@ -1,6 +1,6 @@
 {
   "name": "react-leaflet",
-  "version": "3.2.4",
+  "version": "3.2.5",
   "description": "React components for Leaflet maps",
   "main": "cjs/index.js",
   "module": "esm/index.js",
diff --git a/packages/react-leaflet/src/MapContainer.tsx b/packages/react-leaflet/src/MapContainer.tsx
@@ -71,11 +71,13 @@ export function MapContainer<
       createdRef.current = true
       whenCreated(map)
     }
+  }, [map, whenCreated])
 
+  useEffect(() => {
     return () => {
       map?.remove()
     }
-  }, [map, whenCreated])
+  }, [map])
 
   const [props] = useState({ className, id, style })
   const context = useMemo(

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "react-leaflet",`
`3`		`- "version": "3.2.4",`
	`3`	`+ "version": "3.2.5",`
`4`	`4`	`"description": "React components for Leaflet maps",`
`5`	`5`	`"main": "cjs/index.js",`
`6`	`6`	`"module": "esm/index.js",`
Original file line number	Diff line number	Diff line change
`@@ -71,11 +71,13 @@ export function MapContainer<`
`71`	`71`	`createdRef.current = true`
`72`	`72`	`whenCreated(map)`
`73`	`73`	`}`
	`74`	`+ }, [map, whenCreated])`
`74`	`75`
	`76`	`+ useEffect(() => {`
`75`	`77`	`return () => {`
`76`	`78`	`map?.remove()`
`77`	`79`	`}`
`78`		`- }, [map, whenCreated])`
	`80`	`+ }, [map])`
`79`	`81`
`80`	`82`	`const [props] = useState({ className, id, style })`
`81`	`83`	`const context = useMemo(`