zap unused variables

Author: mohawk2

lib/PDL/LinearAlgebra.pm

@@ -1135,7 +1135,6 @@ sub PDL::mschur {
 	$mult //= 1;
 	$norm //= 1;
 	$jobv = $jobvl = $jobvr = 0 unless wantarray;
-	my $type = $m->type;
 	my $mm = $m->is_inplace ? $m->t : $m->t->copy;
 	my $v = $m->_similar_null;
 	my @w = map $m->_similar_null, $m->_is_complex ? 1 : 1..2;
@@ -1237,7 +1236,6 @@ sub PDL::mschurx {
 	$mult //= 1;
 	$norm //= 1;
 	$jobv = $jobvl = $jobvr = 0 unless wantarray;
-	my $type = $m->type;
 	my $select = long($select_func ? 1 : 0);
 	$sense = pdl(long,0) if !$select_func;
 	$_ = null for my ($info, $sdim, $rconde, $rcondv);
@@ -1393,7 +1391,6 @@ sub PDL::mgschur{
 			($jobvsl == 2 || $jobvsr == 2 || $jobvl == 2 || $jobvr == 2));
 	$mult //= 1;
 	$norm //= 1;
-	my $type = $m->type;
 	my $select = $select_func ? pdl(long,1) : pdl(long,0);
 	$_ = null for my ($info, $sdim);
 	my ($mm, $pp) = map $_->is_inplace ? $_->t : $_->t->copy, $m, $p;
@@ -1510,7 +1507,6 @@ sub PDL::mgschurx{
 	my (@mdims) = $m->dims;
 	$mult //= 1;
 	$norm //= 1;
-	my $type = $m->type;
 	my $select = $select_func ? 1 : 0;
 	$sense = 0 if !$select_func;
 	$_ = null for my ($info, $rconde, $rcondv, $sdim);
@@ -2284,7 +2280,6 @@ sub PDL::mlls {
 	my(@bdims) = $b->dims;
 	my $x;
 	$a = $a->copy;
-	my $type = $a->type;
 	if ( $adims[$di+1] < $adims[$di]) {
 		$x = $a->_similar($adims[$di], $bdims[$di]);
 		$x->slice("$slice_prefix:@{[$bdims[$di+1]-1]}, :@{[$bdims[$di]-1]}") .= $b->t;
@@ -2338,7 +2333,6 @@ sub PDL::mllsy {
 	my($a, $b) = @_;
 	my(@adims) = $a->dims;
 	my(@bdims) = $b->dims;
-	my $type = $a->type;
 	my $rcond = lamch(0);
 	$rcond = $rcond->sqrt - ($rcond->sqrt - $rcond) / 2;
 	$a = $a->t->copy;
@@ -3148,7 +3142,6 @@ sub PDL::mdsvd {
 	my $di = $_[0]->dims_internal;
 	my($m, $jobz) = @_;
 	my(@dims) = $m->dims;
-	my $type = $m->type;
 	$jobz = !wantarray ? 0 : $jobz // 1;
 	my $min = $dims[$di] > $dims[1+$di] ? $dims[1+$di]: $dims[$di];
 	$m = $m->copy;

t/common.pl

@@ -34,22 +34,22 @@
 runtest($a, 'mschurx', $schurx_soln, [0,2,2,undef,1,1]);
 runtest($a, 'mschurx', $schurx_soln, [0,2,2,sub {1},1,1]);
 runtest($a, 'mschurx', $schurx_soln, [0,2,2,sub {1},3,1]);
-my @mgschur_exp = (pdl([-0.35099581,-0.68880032],[0,0.81795847]),
-  pdl([1.026674, -0.366662], [0, -0.279640]));
-runtest($x, 'mgschur', \@mgschur_exp, [sequence(2,2)]);
-runtest($x, 'mgschur', \@mgschur_exp, [sequence(2,2),1,1,1,1,sub {1}]);
-runtest($x, 'mgschur', \@mgschur_exp, [sequence(2,2),2,2,2,2,sub {1},0]);
-runtest($x, 'mgschur', \@mgschur_exp, [sequence(2,2),2,2,2,2,undef,0]);
-runtest($x, 'mgschur', \@mgschur_exp, [sequence(2,2),0,0,2,2,sub {1},1,0]);
-runtest($x, 'mgschur', \@mgschur_exp, [sequence(2,2),0,0,2,2,undef]);
-runtest($x, 'mgschurx', \@mgschur_exp, [sequence(2,2)]);
-runtest($x, 'mgschurx', \@mgschur_exp, [sequence(2,2),1,1,1,1,sub {1}]);
-runtest($x, 'mgschurx', \@mgschur_exp, [sequence(2,2),2,2,2,2,sub {1},0,0,0]);
-runtest($x, 'mgschurx', \@mgschur_exp, [sequence(2,2),2,2,2,2,undef,0,0,0]);
-runtest($x, 'mgschurx', \@mgschur_exp, [sequence(2,2),1,1,1,1,sub {1},2]);
-runtest($x, 'mgschurx', \@mgschur_exp, [sequence(2,2),1,1,1,1,sub {1},3]);
-runtest($x, 'mgschurx', \@mgschur_exp, [sequence(2,2),0,0,1,1,sub {1},1,1,0]);
-runtest($x, 'mgschurx', \@mgschur_exp, [sequence(2,2),0,0,2,2,undef]);
+my $mgschur_exp = [pdl([-0.35099581,-0.68880032],[0,0.81795847]),
+  pdl([1.026674, -0.366662], [0, -0.279640])];
+runtest($x, 'mgschur', $mgschur_exp, [sequence(2,2)]);
+runtest($x, 'mgschur', $mgschur_exp, [sequence(2,2),1,1,1,1,sub {1}]);
+runtest($x, 'mgschur', $mgschur_exp, [sequence(2,2),2,2,2,2,sub {1},0]);
+runtest($x, 'mgschur', $mgschur_exp, [sequence(2,2),2,2,2,2,undef,0]);
+runtest($x, 'mgschur', $mgschur_exp, [sequence(2,2),0,0,2,2,sub {1},1,0]);
+runtest($x, 'mgschur', $mgschur_exp, [sequence(2,2),0,0,2,2,undef]);
+runtest($x, 'mgschurx', $mgschur_exp, [sequence(2,2)]);
+runtest($x, 'mgschurx', $mgschur_exp, [sequence(2,2),1,1,1,1,sub {1}]);
+runtest($x, 'mgschurx', $mgschur_exp, [sequence(2,2),2,2,2,2,sub {1},0,0,0]);
+runtest($x, 'mgschurx', $mgschur_exp, [sequence(2,2),2,2,2,2,undef,0,0,0]);
+runtest($x, 'mgschurx', $mgschur_exp, [sequence(2,2),1,1,1,1,sub {1},2]);
+runtest($x, 'mgschurx', $mgschur_exp, [sequence(2,2),1,1,1,1,sub {1},3]);
+runtest($x, 'mgschurx', $mgschur_exp, [sequence(2,2),0,0,1,1,sub {1},1,1,0]);
+runtest($x, 'mgschurx', $mgschur_exp, [sequence(2,2),0,0,2,2,undef]);
 runtest($x, 'mqr', pdl([-0.49738411,-0.86753043],[-0.86753043,0.49738411]));
 runtest($wide->t, 'mqr', pdl([-0.523069,-0.5023351],[-0.0364932,-0.793903],[-0.851508,0.34260173]));
 runtest($x, 'mrq', pdl([0.27614707,-0.3309725],[0,-1.0396634]));