Skip to content

Commit c3ffcfe

Browse files
committed
Remove weird warning
GitHub deprecated and then removed the unencryted git:// protocol support to access repositories [1]. Using https:// uri for cloning a public repository without an account like is done by vanagon is the preferred way today, so we should not warn about it. 1: https://github.blog/security/application-security/improving-git-protocol-security-github/
1 parent 3641b7e commit c3ffcfe

File tree

1 file changed

+0
-4
lines changed

1 file changed

+0
-4
lines changed

lib/vanagon/component/source.rb

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -69,10 +69,6 @@ def determine_source_type(uri)
6969
# URLs that incorrectly respond to git queries
7070
timeout = 5
7171
if Vanagon::Component::Source::Git.valid_remote?(uri, timeout)
72-
if uri =~ /^http/
73-
VanagonLogger.warn "Using http(s) URIs for github is deprecated. " \
74-
"Use `git:` URI scheme instead."
75-
end
7672
return :git
7773
end
7874

0 commit comments

Comments
 (0)